This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 15500 - Cleanup of Unmatrix code
Summary: Cleanup of Unmatrix code
Status: RESOLVED FIXED
Alias: None
Product: CSS
Classification: Unclassified
Component: Transforms (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal
Target Milestone: ---
Assignee: Simon Fraser
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-10 18:37 UTC by Dirk Schulze
Modified: 2012-02-14 17:02 UTC (History)
4 users (show)

See Also:

Attachments

Description Dirk Schulze 2012-01-10 18:37:11 UTC 
The unmatrix code needs a cleanup. Some variables are not initialized or even defined. Some variable names change suddenly, like matrix to mat.

It should be mentioned which coding language is used. The meaning of matrix[2][3] differ between languages (different order for rows and columns).
Comment 1 Dirk Schulze 2012-02-11 16:31:29 UTC 
I used the 3D pseudo code from FX Transforms. All 3x2 matrices must be transformed to 4x4 matrices before decomposing.

I don't think that we want to provide code for both cases, 2d and 3d.
Comment 2 Dirk Schulze 2012-02-14 17:02:30 UTC 
The 3D code is a lot cleaner.