This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 7607 - TranscodingActionPagination: must not rely on any $_SERVER variable
Summary: TranscodingActionPagination: must not rely on any $_SERVER variable
Status: NEW
Alias: None
Product: mobileOK authoring tools
Classification: Unclassified
Component: Transcoding (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal
Target Milestone: ---
Assignee: Sylvain Lequeux
QA Contact: fd
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-14 09:20 UTC by fd
Modified: 2009-09-14 09:27 UTC (History)
0 users

See Also:

Attachments

Description fd 2009-09-14 09:20:17 UTC 
The transcoding library may be used for all sorts of reasons, to parse content in response to an HTTP request being just one of them.

As such, the library should not make any assumption on the context under which it is being used. Code such as:
 $page = 'http://' . $_SERVER['SERVER_NAME'] . $_SERVER['REQUEST_URI'];
... should not appear anywhere within the library.

In particular, knowing whether we are on the home page or not is irrelevant for the action. A "navigation-type" option would be more relevant:
- adds previous/next links when set to "pages"
- adds "read more" link when set to "more"
... and would leave the door open for new possibilities.

The maximum weight should be adjusted directly in the CMS plug-ins, i.e. there should be no need for the "home" and "home_number" options.
Comment 1 fd 2009-09-14 09:27:03 UTC 
This bug applies to the index of the page to display as well, i.e. it should be an option passed along to the transcoding action through a call to TranscodingAction.setOption rather than a parameter that the transcoding action will determine from the requested URI.