This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 29540 - Spec does not specify units of rotation in all cases
Summary: Spec does not specify units of rotation in all cases
Status: RESOLVED FIXED
Alias: None
Product: FXTF
Classification: Unclassified
Component: Geometry (show other bugs)
Version: unspecified
Hardware: Macintosh MacOS X
: P2 normal
Target Milestone: ---
Assignee: Simon Pieters
QA Contact: sideshowbarker+geometry
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-22 17:52 UTC by Peter Hall
Modified: 2017-05-04 14:53 UTC (History)
1 user (show)

See Also:


Attachments

Description Peter Hall 2016-03-22 17:52:17 UTC
https://drafts.fxtf.org/geometry/#dom-dommatrix-rotateself

In some places, degrees are specifically mentioned. In other places, it does not state. For example:

> 1. rotateSelf(rotX, rotY, rotZ)
> 2. If rotY and rotZ are both missing, set rotZ to the value of rotX and set rotX and rotY to zero.
> 3. If rotY is still missing, set rotY to zero.
> 4. If rotZ is still missing, set rotZ to zero.
> 5. If rotX or rotY are non-zero, set is2D of the current matrix to false.
> 6. Post-multiply the current matrix by each of its 3 rotation matrices about the major axes, first Z using rotZ, then Y using rotY, then X using rotX.
> 7. Return the current matrix.


As an implementor, I would assume this means radians, except that other parts of the document mention degrees.
Comment 1 Simon Pieters 2016-04-04 15:14:37 UTC
Thank you! rotateSelf() fixed in https://github.com/w3c/fxtf-drafts/commit/355f8afe68db85104f66fbbc291450c535368721

Leaving open to check over the rest of the spec...
Comment 2 Simon Pieters 2017-05-04 14:53:49 UTC
I checked all instances of "rotate" and "rotation" and didn't find any further issues.