This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 29133 - Reset Parser State algorithm, in 'sequence' appendMode, should trigger potential discontinuity adjustment logic
Summary: Reset Parser State algorithm, in 'sequence' appendMode, should trigger potent...
Status: RESOLVED FIXED
Alias: None
Product: HTML WG
Classification: Unclassified
Component: Media Source Extensions (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal
Target Milestone: ---
Assignee: Matt Wolenetz
QA Contact: HTML WG Bugzilla archive list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-17 21:27 UTC by Matt Wolenetz
Modified: 2015-10-13 15:33 UTC (History)
4 users (show)

See Also:


Attachments

Description Matt Wolenetz 2015-09-17 21:27:38 UTC
Currently, the following sequence of actions is allowed and produces strange results:
SourceBuffer.appendMode = sequence;
Append [0,10)
Abort
Append [100,110) // or Append [0,10) again

Without the Abort ( == reset parser state), the expected result would be:
[0,20) (assuming each append began with a random access point such that no frames were dropped).

With the Abort and the current Reset Parser State algorithm that is appendMode-agnostic, the result would be:
[0,10 with a large not-real-gap until 100,110)
// or in the alternate case:
[0,10) from the second Append [0,10).

I believe the correct way to fix this problem is to include the following step in the Reset Parser State algorithm:
'If mode equals "sequence": Set group start timestamp equal to the group end timestamp.'

I will prepare a PR shortly for review.
Comment 1 Matt Wolenetz 2015-09-17 22:04:02 UTC
PR is pending review at https://github.com/w3c/media-source/pull/9

Jerry, please take a look.

Thanks,
Matt
Comment 2 Matt Wolenetz 2015-09-17 22:42:44 UTC
fyi - Associated fix in Chromium is pending CR currently at https://codereview.chromium.org/1355673004/
Comment 3 Jerry Smith 2015-09-21 22:17:14 UTC
We see the same gap issue on sequence appends, and support making this change.  I can approve the PR if there are no other objections.
Comment 4 Matt Wolenetz 2015-09-22 19:02:34 UTC
Thank you, Jerry. Note, if the PR is merged, I'll subsequently share another PR to add a related test to MSE wpt as part of fixing this bug.
Comment 5 Paul Cotton 2015-10-13 15:33:31 UTC
Resolved  via https://github.com/w3c/media-source/pull/9