This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 27863 - Not need to specify moving element in top layer and fullscreen stack
Summary: Not need to specify moving element in top layer and fullscreen stack
Status: RESOLVED FIXED
Alias: None
Product: WebAppsWG
Classification: Unclassified
Component: Fullscreen (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: Anne
QA Contact: public-webapps-bugzilla
URL:
Whiteboard:
Keywords:
Depends on: 27865
Blocks:
  Show dependency treegraph
 
Reported: 2015-01-20 06:05 UTC by Xidorn Quan
Modified: 2015-07-03 12:29 UTC (History)
2 users (show)

See Also:


Attachments

Description Xidorn Quan 2015-01-20 06:05:50 UTC
https://fullscreen.spec.whatwg.org/#concept-fullscreen-add

[[
To add an element on a document's fullscreen element stack, add, or move if already present, it on top of document's browsing context's top layer, and then add, or move if already present, it on top of document's fullscreen element stack.
]]

Since the spec includes the following items in the "fullscreen element ready check" algorithm:

[[
element's node document's fullscreen element stack is either empty or its top element is an inclusive ancestor of element. 
]]

I don't think it is possible that an element already in the stack could be added to the stack again.

Hence I suggest to remove the "or move if already present".
Comment 1 Anne 2015-01-20 08:19:56 UTC
For top layer this is definitely untrue as that concept is shared with other features, such as <dialog>.

Why do you think it is true for the fullscreen element stack. It could be both non-empty and filled with elements that are not inclusive ancestors of the element in question, no?
Comment 2 Xidorn Quan 2015-01-20 08:48:50 UTC
(In reply to Anne from comment #1)
> For top layer this is definitely untrue as that concept is shared with other
> features, such as <dialog>.

OK

> Why do you think it is true for the fullscreen element stack. It could be
> both non-empty and filled with elements that are not inclusive ancestors of
> the element in question, no?

Because in this case, the requestFullscreen() method will fail in "fullscreen element ready check" step, which stops this method from adding element to the stack.
Comment 3 Anne 2015-01-20 08:56:22 UTC
Yeah sorry, I guess you're right. I'm going to hold off on fixing this until I get a chance to fix the other outstanding issues.
Comment 4 Anne 2015-07-03 12:29:56 UTC
This was fixed by merging the two concepts in bug 27865.