This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 27239 - Update SourceBuffer.appendStream() and related algorithms to use ReadableByteStream.
Summary: Update SourceBuffer.appendStream() and related algorithms to use ReadableByte...
Status: RESOLVED MOVED
Alias: None
Product: HTML WG
Classification: Unclassified
Component: Media Source Extensions (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal
Target Milestone: CR
Assignee: Matt Wolenetz
QA Contact: HTML WG Bugzilla archive list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 28465
  Show dependency treegraph
 
Reported: 2014-11-04 22:02 UTC by Aaron Colwell
Modified: 2015-10-13 22:43 UTC (History)
7 users (show)

See Also:


Attachments

Description Aaron Colwell 2014-11-04 22:02:47 UTC
Update the SourceBuffer.appendStream() stream parameter to be a ReadableByteStream instead of a Stream. Update all related algorithms and update the Streams API spec reference.
Comment 1 Aaron Colwell 2014-12-03 06:37:50 UTC
Change committed...
https://github.com/w3c/media-source/commit/502f28af99d3d38923a109c824f3a284062d7135

Updated appendStream() to use ReadableStream for now since the W3C streams spec doesn't even have a class definition for ReadableByteStream.
Comment 2 Aaron Colwell 2015-04-03 16:27:42 UTC
The current status of this bug is that we are waiting for the dust to settle from https://github.com/whatwg/streams/issues/253 and for the ReadableByteStream stuff to move from https://github.com/whatwg/streams/blob/master/BinaryExtension.md into the main Streams spec so that it can be linked to from MSE. I reached out to Domenic and Takeshi about a week or 2 ago and it sounded like they expected this to be done in the next few weeks.

Once the Streams API work is done, then the MSE spec needs to be reworked to use the current incarnation of the API. The MSE spec also needs to make sure it uses whatever Streams mechanisms are available to guarantee that it becomes the exclusive reader of the stream. We definitely want appendStream() operations to block JS read access while the append is occuring to avoid non-deterministic behavior.
Comment 3 Paul Cotton 2015-04-10 21:39:03 UTC
(In reply to Aaron Colwell from comment #2)
> The current status of this bug is that we are waiting for the dust to settle
> from https://github.com/whatwg/streams/issues/253 and for the
> ReadableByteStream stuff to move from
> https://github.com/whatwg/streams/blob/master/BinaryExtension.md into the
> main Streams spec so that it can be linked to from MSE. I reached out to
> Domenic and Takeshi about a week or 2 ago and it sounded like they expected
> this to be done in the next few weeks.
> 
> Once the Streams API work is done, then the MSE spec needs to be reworked to
> use the current incarnation of the API. The MSE spec also needs to make sure
> it uses whatever Streams mechanisms are available to guarantee that it
> becomes the exclusive reader of the stream. We definitely want
> appendStream() operations to block JS read access while the append is
> occuring to avoid non-deterministic behavior.

https://github.com/whatwg/streams/issues/253 is now marked as closed.

Do we know when ReadableByteStream will move in the main Streams spec?

/paulc
Comment 4 Paul Cotton 2015-04-11 16:01:58 UTC
(In reply to Paul Cotton from comment #3)
> https://github.com/whatwg/streams/issues/253 is now marked as closed.
> 
> Do we know when ReadableByteStream will move in the main Streams spec?
> 

Apparently the master Stream issue for the implementation of the ReadableByteStream is:
https://github.com/whatwg/streams/issues/300

See Domenic's reply to my query at:
https://github.com/whatwg/streams/issues/253#issuecomment-91706806 

/paulc
Comment 5 Anne 2015-04-14 07:44:50 UTC
Is appendStream() really the best name here? This is a one-off operation, no? Append sounds like the underlying object has a list of streams.
Comment 6 Paul Cotton 2015-04-14 14:24:31 UTC
(In reply to Paul Cotton from comment #4)
> (In reply to Paul Cotton from comment #3)
> > https://github.com/whatwg/streams/issues/253 is now marked as closed.
> > 
> > Do we know when ReadableByteStream will move in the main Streams spec?
> > 
> 
> Apparently the master Stream issue for the implementation of the
> ReadableByteStream is:
> https://github.com/whatwg/streams/issues/300
> 
> See Domenic's reply to my query at:
> https://github.com/whatwg/streams/issues/253#issuecomment-91706806 
> 
> /paulc

And now see Takeshi Yoshino's reply.  ETA for integration is now week of Apr 20:
https://github.com/whatwg/streams/issues/253#issuecomment-92841148 

/paulc
Comment 7 David Dorwin 2015-04-15 17:21:52 UTC
In the meantime, we should add an Issue box to the appendStream() algorithm that indicates that it is not final and is subject to change. This is especially important MSE is in CR and presumably stable. There was support for this at the f2f.
Comment 8 Paul Cotton 2015-05-07 15:03:15 UTC
(In reply to David Dorwin from comment #7)
> In the meantime, we should add an Issue box to the appendStream() algorithm
> that indicates that it is not final and is subject to change. This is
> especially important MSE is in CR and presumably stable. There was support
> for this at the f2f.

We can now reference https://streams.spec.whatwg.org/#rbs for the definition of ReadableByteStream in the Streams spec.

For reference see https://github.com/whatwg/streams/issues/253#issuecomment-99877403

/paulc
Comment 9 Matt Wolenetz 2015-10-13 22:43:31 UTC
This bug has been migrated to the GitHub issue tracker. Please follow/update progress using the GitHub issue:
https://github.com/w3c/media-source/issues/14