This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 26601 - Populate fullscreenElements later in requestFullscreen()
Summary: Populate fullscreenElements later in requestFullscreen()
Status: RESOLVED FIXED
Alias: None
Product: WebAppsWG
Classification: Unclassified
Component: Fullscreen (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal
Target Milestone: ---
Assignee: Anne
QA Contact: public-webapps-bugzilla
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-18 22:09 UTC by Philip Jägenstedt
Modified: 2014-08-26 11:57 UTC (History)
2 users (show)

See Also:


Attachments

Description Philip Jägenstedt 2014-08-18 22:09:55 UTC
http://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen

fullscreenElements is populated synchronously, but before the animation frame task is run, the elements of fullscreenElements may have been moved in ways that still passes the ready checks, but leaves the resulting fullscreen element stacks inconsistent, for example if the pending element is moved between two iframes immediately after requestFullscreen() returns.

The fix should be to populate the list of newly fullscreen elements in the animation frame task, immediately before pushing to stacks and firing events.

Note that in such a rewrite, the ready check could be performed for only the pending element, since it is now recursive.
Comment 2 Philip Jägenstedt 2014-08-26 11:57:51 UTC
LGTM and follow-up:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26671