This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 26016 - [WebVTT] lineAlign/positionAlign IDL attributes should not be AlignSetting
Summary: [WebVTT] lineAlign/positionAlign IDL attributes should not be AlignSetting
Status: RESOLVED FIXED
Alias: None
Product: TextTracks CG
Classification: Unclassified
Component: WebVTT (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal
Target Milestone: ---
Assignee: This bug has no owner yet - up for the taking
QA Contact: Web Media Text Tracks CG
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-08 21:42 UTC by Philip Jägenstedt
Modified: 2014-06-11 11:41 UTC (History)
2 users (show)

See Also:

Attachments

Description Philip Jägenstedt 2014-06-08 21:42:26 UTC 
AlignSetting includes "left" and "right", but tables in the lineAlign/positionAlign setters do not, making the behavior undefined.
Comment 1 Silvia Pfeiffer 2014-06-09 02:15:00 UTC 
I was in fact wondering if I need to define a different type for them. My thoughts were that if a string is used that is not identified in the table, lineAlign and positionAlign would not be set, which is exactly the same as if those strings were not listed, so I could skip defining a new type. Is that not appropriate? If not, I'm happy to create a new type.
Comment 2 Philip Jägenstedt 2014-06-09 13:38:38 UTC 
If an enum { "start", "middle", "end" } is used in IDL and "left" is set an exception (TypeError I think) is thrown, so that would be appropriate.
Comment 3 Silvia Pfeiffer 2014-06-09 14:26:14 UTC 
Ok, feel free to prepare the patch
Comment 4 Philip Jägenstedt 2014-06-11 11:41:54 UTC 
Fixed in https://github.com/w3c/webvtt/pull/109