This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 25892 - SignalingStateChange event should be fired only if there is a change in signaling state.
Summary: SignalingStateChange event should be fired only if there is a change in signa...
Status: RESOLVED FIXED
Alias: None
Product: WebRTC Working Group
Classification: Unclassified
Component: WebRTC API (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: Web RTC Working Group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-27 10:11 UTC by Kiran
Modified: 2014-06-09 08:47 UTC (History)
2 users (show)

See Also:


Attachments

Description Kiran 2014-05-27 10:11:46 UTC
SignalingStateChange event is being fired as a result of setLocalDescription / setRemoteDescription.
But there are cases where signaling state will not be changed as a result of setLocalDescription / setRemoteDescription, for example.

pc.createOffer()
pc.setLocalDescription()
onSignalingStateChange() -- Event fired as a result of signaling state change
// Again if createOffer is called for second time.
pc.createOffer()
pc.setLocalDescription()
// There is no change in the signaling state but still onSignalingStateChange() event is firing.

Spec should modify text in setLocalDescription step 7 from


Fire a simple event named signalingstatechange at connection.

to 

Fire a simple event named signalingstatechange at connection, if signaling state is changed.
Comment 1 Adam Bergkvist 2014-06-04 08:32:10 UTC
I believe you are right.

Proposed fix: https://github.com/fluffy/webrtc-w3c/commit/406f1aa7248583e8823d3560e61c3060f75a8e69