This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 25656 - [D3E] Another corrections and suggestions
Summary: [D3E] Another corrections and suggestions
Status: RESOLVED FIXED
Alias: None
Product: WebAppsWG
Classification: Unclassified
Component: HISTORICAL - DOM3 Events (show other bugs)
Version: unspecified
Hardware: PC Windows NT
: P2 normal
Target Milestone: ---
Assignee: Travis Leithead [MSFT]
QA Contact: public-webapps-bugzilla
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-11 17:16 UTC by Arkadiusz Michalski (Spirit)
Modified: 2014-05-15 00:52 UTC (History)
2 users (show)

See Also:


Attachments

Description Arkadiusz Michalski (Spirit) 2014-05-11 17:16:13 UTC
A few another corrections what I found.

===

Example 22:

"Regardless of the current locale or the modifier key state, pressing the key labelled '2' on a US keyboard always results in 'Digit2' in the code attribute." < 'Digit2' is .code, not .key (use class="code")

Example 27:

"The key value for the key labeled 'Q' will revert to its unshifted value for the keyup event:" << if 'Q' is labeled maybe use class="glyph"?

Example 31:

"For example, on some MacOS keyboards, the key labeled 'delete' functions the same as..." << the same like above, maybe for 'delete' use class="glyph"?

dead key (in glossary)
"...such as a character with diacritical marks (e.g., ö, é, â)." << te last characters what type is it (glyph, key or other)?

===

5.2.3.1.3 Dictionary MouseEventInit Members
"Initializes the altKey attribute of the MouseEvent object to true if the altKey modifier key is to be considered depressed, false otherwise."

'altKey modifier key' looks strange, we don't see what exactly it is. Better if use the same convention like for KeyboardEvent (5.2.6.1.1 Attributes) or all mouse/keyboard event tables.

This applies to altKey/ctrlKey/metaKey/shiftKey in Dictionary (for MouseEventInit/KeyboardEventInit).

5.2.6.1.1 Attributes
metaKey of type boolean, readonly 
 true if the meta (Meta) key modifier was active. << maybe 'Meta' (meta) with class="key"?

shiftKey of type boolean, readonly 
 true if the shift (Shift) key modifier was active. < maybe 'Shift' (shift) with class="key"?

===

In some places you can use <code> around text/link (as we have in all similar cases)

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#event-type-focusin
focusin table, green box:
"... gaining focus without the use of the blur or focusout event types." << for focusout 

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#widl-EventTarget-addEventListener
addEventListener (in table):
"...implements EventListener, then its handleEvent method MUST..." << for handleEvent
"This parameter MUST be optional. If not provided, the EventTarget.addEventListener method MUST..." << for EventTarget.addEventListener

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#widl-EventTarget-removeEventListener
removeEventListener (in table):
"This parameter MUST be optional. If not provided, the EventTarget.removeEventListener method MUST behave a..." << for EventTarget.removeEventListener

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#interface-EventListener
Interface EventListener (first green box):
"...interface and register their event listener using EventTarget.addEventListener. In JavaScript..." << for EventTarget.addEventListener

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#interface-EventTarget
4.3 Interface EventTarget (second green box):
"Note: In addition to the EventTarget.addEventListener method, some..." << EventTarget.addEventListener

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#constants
4.1.4 Constants (NONE):
"...being dispatched, i.e., the Event.eventPhase is being observered prior to calling EventTarget.dispatchEvent() or following the ..." << for Event.eventPhase and EventTarget.dispatchEvent()

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#widl-KeyboardEvent-repeat
"...the first key event with a repeat attribute value of 'true' MUST serve as an indication..." << for repeat

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#h5_events-keyboard-event-order
"...the event target will be the HTML <body> element..." << for <body>
And the same in:
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#event-type-keydown
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#event-type-keyup
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#event-type-keypress

===

And the last, now style for <a> is unhelpful, especialy when you use <a> + <code>. This applies mainly to the types of events because they use class="eventtype" with:
text-decoration: none;

Somtimes you use this class to other <a><code></code></a>, not only event names. This styling does not allow to distinguish between what is a link and what is not. Sometimes whe have just <code>, but sometimes <a><code></code></a>, and all looks the same. 

So making better style for references is realy necessary.
Comment 1 Travis Leithead [MSFT] 2014-05-12 23:58:03 UTC
(In reply to spiritRKS1910 from comment #0)
> A few another corrections what I found.
> 
> 5.2.6.1.1 Attributes
> metaKey of type boolean, readonly 
>  true if the meta (Meta) key modifier was active. << maybe 'Meta' (meta)
> with class="key"?
> 
> shiftKey of type boolean, readonly 
>  true if the shift (Shift) key modifier was active. < maybe 'Shift' (shift)
> with class="key"?

Fixed by: https://dvcs.w3.org/hg/dom3events/rev/c990dc0929dd

Working on the rest now...
Comment 2 Arkadiusz Michalski (Spirit) 2014-05-13 00:30:28 UTC
true if the shift (Shift) key modifier was active. << 'Shift'

Immediately submit because probably I forget tomorrow:)
Comment 3 Travis Leithead [MSFT] 2014-05-15 00:52:42 UTC
Now addressed in changelist: https://dvcs.w3.org/hg/dom3events/rev/58f7746cd6f7