This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 25295 - Small bugs in the descriptions
Summary: Small bugs in the descriptions
Status: RESOLVED FIXED
Alias: None
Product: WebAppsWG
Classification: Unclassified
Component: HISTORICAL - DOM3 Events (show other bugs)
Version: unspecified
Hardware: PC Windows NT
: P2 normal
Target Milestone: ---
Assignee: Travis Leithead [MSFT]
QA Contact: public-webapps-bugzilla
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-09 07:49 UTC by Arkadiusz Michalski (Spirit)
Modified: 2014-04-16 00:06 UTC (History)
3 users (show)

See Also:


Attachments

Description Arkadiusz Michalski (Spirit) 2014-04-09 07:49:09 UTC
Hi, I gathered together a few minor bugs:

-----------
Missing one argument in initCompositionEvent()
Now we have five:
void initCompositionEvent (DOMString typeArg, boolean bubblesArg, boolean cancelableArg, Window? viewArg, DOMString? dataArg);
Should be six:
void initCompositionEvent (DOMString typeArg, boolean bubblesArg, boolean cancelableArg, Window? viewArg, long detailArg, DOMString? dataArg);

-----------
Missing define the FocusEventInit dictionary. All other interface have them.

-----------
Wrong comment in some place:

4.2 Interface CustomEvent Introduced in DOM Level 2 << should be Introduced in DOM Level 3
4.3 Interface EventTarget Introduced in DOM Level 3 << should be Introduced in DOM Level 2

MouseEvent.buttons << sholud be mark that Introduced in DOM Level 3

-----------
Target for event type is not complete. I understand that you wrote:
"When used with an [XML 1.0] or [HTML5] application, the specifications of those languages MAY restrict the semantics and scope (in particular the possible event targets) associated with an event type."

But now we have different event target within the same specification:
for event resize (https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#event-type-resize) we have defaultView but in event table (https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#h4_event-types-list) we have defaultView, Document.

-----------
In the table that defines the types of events, rows "Context info: UIEvent.view" somtimes have only defaultView, but there is also defaultView, null. These are the correct values? Look:
blur UIEvent.view: defaultView
focus, focusin, focusout UIEvent.view: defaultView, null
Any explanation why they have different values​​?

Te same situtation:
load, unload, abort, error, select UIEvent.view: defaultView, null
resize, scroll UIEvent.view: defaultView
Comment 1 Arkadiusz Michalski (Spirit) 2014-04-10 00:13:51 UTC
The next few;

-----------
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#idl-interface-MouseEvent-initializers
partial interface MouseEvent {
    // Deprecated in DOM Level 3 << should be "Changed and depreaced in DOM Level 3" 
};

This method has one additional argument (when compared with D2E) so better inform about them.

-----------
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#idl-def-Event
IDL for isTrusted has the form: readonly attribute boolean isTrusted;

http://dom.spec.whatwg.org/#interface-event
In new DOM we have additional extended attribute: [Unforgeable] readonly attribute boolean isTrusted;

It's important and should be add.

Similar situation (but less meaning):

interface DocumentEvent {
    Event createEvent (DOMString eventInterface);
};

change to:

interface DocumentEvent {
    [NewObject] Event createEvent (DOMString eventInterface);
};

-----------
Please for all parameters in method/constructor/table description delete "Arg" sufiks. It's unnecessary and extends the descriptions (especially init*Event). I checked few other specyfications and none of them use "Arg". This will enhance convergence between documents.

Even in D3E sometimes you don't use them.
Comment 2 Gary Kacmarcik 2014-04-15 23:03:16 UTC
(Thank you for taking the time to make these comments.  I've broken some of these issues out into separate bugs because it's harder to track the items when they're in a single bug.)

(1) Missing one argument in initCompositionEvent()...

These are deprecated, so we're not updating the definitions. We would update them only if a browser vendor is shipping a version with the extra argument.

(2) Missing define the FocusEventInit dictionary...

Done.

(3) Wrong comment in some place...

Done.

(4) Target for event type is not complete...

https://www.w3.org/Bugs/Public/show_bug.cgi?id=25357

(5) Review "Context info: UIEvent.view"...

https://www.w3.org/Bugs/Public/show_bug.cgi?id=25358

(6) initMouseEvent changed in DOM3...

Done. Fixed spec by removing |buttons| parameter. See discussion in 25346.

(7) [unforgeable] isTrusted and [NewObject] createEvent

https://www.w3.org/Bugs/Public/show_bug.cgi?id=25359

(8) Remove 'Arg' suffix from arguments

I'll do this as part of a later cleanup. Please create a bug if you want to track progress.
Comment 3 Arkadiusz Michalski (Spirit) 2014-04-15 23:24:07 UTC
> (Thank you for taking the time to make these comments.  I've broken some of
> these issues out into separate bugs because it's harder to track the items
> when they're in a single bug.)

Ok, and have small question, if I have realy small bugs like dead link, missing "(" etc., then open for all this case separate bug or take all and wriite in one place?

> (1) Missing one argument in initCompositionEvent()...
> 
> These are deprecated, so we're not updating the definitions. We would update
> them only if a browser vendor is shipping a version with the extra argument.

Problem is that Firefox and IE expected 6 arguments, with 5 throw error.
TypeError: Not enough arguments to CompositionEvent.initCompositionEvent.
That's why I mentioned about it.
Comment 4 Arkadiusz Michalski (Spirit) 2014-04-15 23:48:41 UTC
I checked this more closely:

https://developer.mozilla.org/en-US/docs/Web/API/CompositionEvent
http://msdn.microsoft.com/en-us/library/ie/ff975300%28v=vs.85%29.aspx

So missing is:
DOMString  locale 
(provide in http://www.w3.org/TR/uievents#widl-CompositionEvent-locale)

Chrome doesn't support locale property so that why initCompositionEvent() take only 5 arguments.
Comment 5 Gary Kacmarcik 2014-04-16 00:06:37 UTC
(In reply to spiritRKS1910 from comment #3)
> > (Thank you for taking the time to make these comments.  I've broken some of
> > these issues out into separate bugs because it's harder to track the items
> > when they're in a single bug.)
> 
> Ok, and have small question, if I have realy small bugs like dead link,
> missing "(" etc., then open for all this case separate bug or take all and
> wriite in one place?

Please group related bugs, but have a separate bug for each group. E.g., one bug for all the broken links, one with all the typos, ...

> > (1) Missing one argument in initCompositionEvent()...
> > 
> > These are deprecated, so we're not updating the definitions. We would update
> > them only if a browser vendor is shipping a version with the extra argument.
> 
> Problem is that Firefox and IE expected 6 arguments, with 5 throw error.
> TypeError: Not enough arguments to CompositionEvent.initCompositionEvent.
> That's why I mentioned about it.

Ah. |locale| was moved into UIEvents since we don't (yet) have a good definition for it. It seems weird to include it as a param for initCompositionEvent when we don't have it as an attribute, but if that's what FF and IE expect that we need to document the real world.