This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.
Created attachment 1436 [details] build.xml_download_dependencies.patch Version 1.24 of build.xml changes old dependencies and adds new ones: > cvs diff -u -w -r 1.23 -r 1.24 build.xml Index: build.xml =================================================================== RCS file: /sources/public/2002/css-validator/build.xml,v retrieving revision 1.23 retrieving revision 1.24 diff -u -w -r1.23 -r1.24 --- build.xml 1 Nov 2011 07:51:20 -0000 1.23 +++ build.xml 13 Jan 2014 10:01:30 -0000 1.24 @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<!-- $Id: build.xml,v 1.23 2011-11-01 07:51:20 ylafon Exp $ --> +<!-- $Id: build.xml,v 1.24 2014-01-13 10:01:30 ylafon Exp $ --> <project default="jar" name="W3C CSS Validator"> <!-- =================================================================== --> @@ -32,14 +32,18 @@ <condition property="prepare.run"> <and> <available file="lib/jigsaw.jar"/> + <available file="lib/commons-beanutils-1.9.0.jar"/> <available file="lib/commons-collections-3.2.1.jar"/> + <available file="lib/commons-digester-1.8.1.jar"/> <available file="lib/commons-lang-2.6.jar"/> + <available file="lib/commons-logging-1.1.1.jar"/> <available file="lib/velocity-1.7.jar"/> <available file="lib/xercesImpl.jar"/> <available file="lib/xml-apis.jar"/> - <available file="lib/tagsoup-1.2.jar"/> + <available file="lib/tagsoup-1.2.1.jar"/> <available file="lib/servlet-api-2.5-6.0.0.jar"/> - <available file="lib/htmlparser-1.3.1.jar"/> + <available file="lib/htmlparser-1.4.jar"/> + <available file="lib/velocity-tools-generic-2.0.jar"/> </and> </condition> </target> The problem is the new dependencies aren't actually downloaded afterwards in "prepare" target, so built jars and wars aren't working correctly. This renders 'prepare.check' non-working, because it keeps looking for jars that are newver downloaded. Fixing this is trivial, please take a look at
> The problem is the new dependencies aren't actually downloaded afterwards in > "prepare" target, so built jars and wars aren't working correctly. This > renders 'prepare.check' non-working, because it keeps looking for jars that > are newver downloaded. Fixing this is trivial, please take a look at Continuing, submitted prematurely. Fixing this is trivial, please take a look at attachment "build.xml_download_dependencies.patch". I think we ended up in such a state because lib/ is never deleted in "clean" target, so new jars were present there on the developer's machine (possibly copied manually), but are never downloaded on other people's machines, because there's no rules for this in "prepare" target. I'll add patch for cleaning lib directory, too. The patched build.xml produced working css-validator.jar and css-validator.war (tested in Tomcat 6).
Created attachment 1437 [details] build.xml_clean_lib_dir.patch Adding a patch for cleaning lib directory in "clean" target.
Created attachment 1592 [details] Patch rebased to "cvs co -D 2015-03-01"
Created attachment 1593 [details] build.xml_download_dependencies.patch Patch rebased to "cvs co -D 2015-03-01".
Created attachment 1594 [details] build.xml_clean_lib_dir.patch Patch rebased to "cvs co -D 2015-03-01".