This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 24133 - quit is not documented.
Summary: quit is not documented.
Status: RESOLVED FIXED
Alias: None
Product: Browser Test/Tools WG
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal
Target Milestone: ---
Assignee: Simon Stewart
QA Contact: Browser Testing and Tools WG
URL:
Whiteboard:
Keywords:
: 26495 (view as bug list)
Depends on:
Blocks: 20860
  Show dependency treegraph
 
Reported: 2013-12-19 00:48 UTC by David Burns :automatedtester
Modified: 2014-08-07 22:44 UTC (History)
2 users (show)

See Also:


Attachments

Description David Burns :automatedtester 2013-12-19 00:48:24 UTC
we have references to quit but it doesn't seem to be documented. We need to have a section on this to document the method and the desired behaviour of cleaning up after itself.

https://code.google.com/p/selenium/wiki/JsonWireProtocol#DELETE_/session/:sessionId
Comment 1 David Burns :automatedtester 2014-02-25 19:30:41 UTC
Link to quit from close()
Comment 2 David Burns :automatedtester 2014-08-04 08:55:03 UTC
*** Bug 26495 has been marked as a duplicate of this bug. ***
Comment 3 David Burns :automatedtester 2014-08-06 18:27:02 UTC
https://dvcs.w3.org/hg/webdriver/rev/f4d1b275fa16
Comment 4 Andreas Tolfsen 2014-08-07 10:13:45 UTC
I'm unclear about a few things related to this patch:

- What does it mean that a “session does not exist” on the user agent?
- How should the windows be closed?  Also, I thought the driver was in charge of doing it; not the UA
- Should the sessionId field be set to null in the response from the quit command?  (That's how I'm interpreting it, but is this what Selenium does?)
Comment 5 David Burns :automatedtester 2014-08-07 22:44:49 UTC
(In reply to Andreas Tolfsen from comment #4)
> I'm unclear about a few things related to this patch:
> 
> - What does it mean that a “session does not exist” on the user agent?

The user agent needs to keep track of sessionIds (https://dvcs.w3.org/hg/webdriver/raw-file/tip/webdriver-spec.html#widl-WebDriver-sessionId). If the sessionId doesnt exist then raise an error.

> - How should the windows be closed?  Also, I thought the driver was in
> charge of doing it; not the UA

The driver tells the UA to close it. Since we are putting the driver in the User Agent I don't think we need to document the exact mechanics of this.

> - Should the sessionId field be set to null in the response from the quit
> command?  (That's how I'm interpreting it, but is this what Selenium does?)

If we don't set the UserAgent value of sessionId to null I worry that any commands sent to it. I know that local end never checks the sessionId when it is sent back so don't know if this really matters