Bug 24130 - Shift_JIS decoder should support PUA code points
Summary: Shift_JIS decoder should support PUA code points
Status: RESOLVED FIXED
Alias: None
Product: WHATWG
Classification: Unclassified
Component: Encoding (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Target Milestone: Unsorted
Assignee: Anne
QA Contact: sideshowbarker+encodingspec
URL:
Whiteboard:
Keywords:
Depends on: 16862
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-18 15:54 UTC by Masatoshi Kimura
Modified: 2014-05-12 14:36 UTC (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Masatoshi Kimura 2013-12-18 15:54:15 UTC
+++ This bug was initially created as a clone of Bug #16862 +++

(I'm concentrating Shift_JIS atm because I'm more familiar with the encoding than other foreign encodings.)

Presto discontinued. Now virtually all browsers support the EUDC code range. But the spec doesn't reflect the reality.
Comment 1 Anne 2014-03-28 12:18:52 UTC
Do you have a pointer to what changes this would require?
Comment 2 Masatoshi Kimura 2014-03-28 12:42:29 UTC
The current decoder step 3.4 would be broken down as follows:
3.4. Let code point be null, if pointer is null, and run these substeps otherwose:
3.4.1. Let code point be index code point for pointer in index jis0208.
3.4.2. If code point is null and pointer is in range between 8836 and 10528, let code point be 0xE000 + (pointer - 8836).
Comment 3 Anne 2014-04-10 14:54:25 UTC
This was removed in https://github.com/whatwg/encoding/commit/651f672ee988702da03f56ad8bdfda00b51a21ea That suggests a simpler approach here.
Comment 5 Anne 2014-05-12 14:36:55 UTC
This fix was wrong. I went with a fix closer to that suggested in comment 2:

https://github.com/whatwg/encoding/commit/236196e8ce274c44ab45109dfc8da9539ae44e1d