Bug 20360 - 2d.fillStyle.parse.rgb-eof.html & 2d.fillStyle.parse.rgba-eof.html missed a bracket
2d.fillStyle.parse.rgb-eof.html & 2d.fillStyle.parse.rgba-eof.html missed a b...
Status: NEW
Product: HTML WG
Classification: Unclassified
Component: testsuite
unspecified
PC All
: P2 normal
: ---
Assigned To: zqzhang
HTML WG Bugzilla archive list
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-12 15:43 UTC by zqzhang
Modified: 2012-12-13 12:23 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description zqzhang 2012-12-12 15:43:48 UTC
* http://w3c-test.org/html/tests/approved/canvas/2d.fillStyle.parse.rgb-eof.html
* http://w3c-test.org/html/tests/approved/canvas/2d.fillStyle.parse.rgba-eof.html

missed a bracket:

ctx.fillStyle = 'rgb(0,255,0'; 
ctx.fillStyle = 'rgba(0,255,0,1';
Comment 1 zqzhang 2012-12-12 15:47:21 UTC
diff --git a/tests/approved/canvas/2d.fillStyle.parse.rgb-eof.html b/tests/approved/canvas/2d.fillStyle.parse.rgb-eof.html
--- a/tests/approved/canvas/2d.fillStyle.parse.rgb-eof.html
+++ b/tests/approved/canvas/2d.fillStyle.parse.rgb-eof.html
@@ -18,16 +18,16 @@
 <canvas id="c" class="output" width="100" height="50"><p class="fallback">FAIL (fallback content)</p></canvas>
 <p class="output expectedtext">Expected output:<p><img src="2d.fillStyle.parse.rgb-eof.png" class="output expected" id="expected" alt="">
 <ul id="d"></ul>
 <script>
 _addTest(function(canvas, ctx) {
 
 
 ctx.fillStyle = '#f00';
-ctx.fillStyle = 'rgb(0, 255, 0';
+ctx.fillStyle = 'rgb(0, 255, 0)';
 ctx.fillRect(0, 0, 100, 50);
 _assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
 
 
 });
 </script>
 
diff --git a/tests/approved/canvas/2d.fillStyle.parse.rgba-eof.html b/tests/approved/canvas/2d.fillStyle.parse.rgba-eof.html
--- a/tests/approved/canvas/2d.fillStyle.parse.rgba-eof.html
+++ b/tests/approved/canvas/2d.fillStyle.parse.rgba-eof.html
@@ -18,16 +18,16 @@
 <canvas id="c" class="output" width="100" height="50"><p class="fallback">FAIL (fallback content)</p></canvas>
 <p class="output expectedtext">Expected output:<p><img src="2d.fillStyle.parse.rgba-eof.png" class="output expected" id="expected" alt="">
 <ul id="d"></ul>
 <script>
 _addTest(function(canvas, ctx) {
 
 
 ctx.fillStyle = '#f00';
-ctx.fillStyle = 'rgba(0, 255, 0, 1';
+ctx.fillStyle = 'rgba(0, 255, 0, 1)';
 ctx.fillRect(0, 0, 100, 50);
 _assertPixel(canvas, 50,25, 0,255,0,255, "50,25", "0,255,0,255");
 
 
 });
 </script>
Comment 2 zqzhang 2012-12-12 15:49:28 UTC
By manually running the tests after the patch above on Chrome Version 23.0.1271.95 m and Firefox 17.0.1, they passed.