Bug 19857 - onnegotationneeded syntax error
onnegotationneeded syntax error
Status: RESOLVED FIXED
Product: WebRTC Working Group
Classification: Unclassified
Component: WebRTC API
unspecified
PC Windows NT
: P2 normal
: ---
Assigned To: Web RTC Working Group
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-05 01:18 UTC by Yang Sun
Modified: 2012-11-05 02:03 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yang Sun 2012-11-05 01:18:03 UTC
as pointed out by Iskren Chernev [iskren@imo.im] in email thread

onnegotationneeded should be onnegotiationneeded, there should be an "i" after first t.

/////////////////First Change begin//////////////////////////////////////
[Constructor (RTCConfiguration configuration, optional MediaConstraints constraints)]
interface RTCPeerConnection : EventTarget  {
    void           createOffer (RTCSessionDescriptionCallback successCallback, optional RTCPeerConnectionErrorCallback failureCallback, optional MediaConstraints constraints);
    void           createAnswer (RTCSessionDescriptionCallback successCallback, optional RTCPeerConnectionErrorCallback? failureCallback = null, optional MediaConstraints constraints = null);
    void           setLocalDescription (RTCSessionDescription description, optional RTCVoidCallback successCallback, optional RTCPeerConnectionErrorCallback failureCallback);
    readonly attribute RTCSessionDescription localDescription;
    void           setRemoteDescription (RTCSessionDescription description, optional RTCVoidCallback successCallback, optional RTCPeerConnectionErrorCallback failureCallback);
    readonly attribute RTCSessionDescription remoteDescription;
    readonly attribute RTCPeerState          readyState;
    void           updateIce (optional RTCConfiguration? configuration = null, optional MediaConstraints? constraints = null);
    void           addIceCandidate (RTCIceCandidate candidate);
    readonly attribute RTCGatheringState     iceGatheringState;
    readonly attribute RTCIceState           iceState;
    readonly attribute MediaStreamArray      localStreams;
    readonly attribute MediaStreamArray      remoteStreams;
    RTCDataChannel createDataChannel ([TreatNullAs=EmptyString] DOMString label, optional RTCDataChannelInit dataChannelDict);
             attribute EventHandler          ondatachannel;
    void           addStream (MediaStream stream, optional MediaConstraints constraints);
    void           removeStream (MediaStream stream);
    void           setIdentityProvider (DOMString provider, optional DOMString protocol, optional DOMString username);
    void           getIdentityAssertion ();
    readonly attribute RTCIdentityAssertion? peerIdentity;
    void           getStats (MediaStreamTrack? selector, RTCStatsCallback successCallback, optional RTCPeerConnectionErrorCallback failureCallback);
    void           close ();
             attribute EventHandler          ////onnegotationneeded->onnegotiationneeded/////;
             attribute EventHandler          onicecandidate;
             attribute EventHandler          onopen;
             attribute EventHandler          onstatechange;
             attribute EventHandler          onaddstream;
             attribute EventHandler          onremovestream;
             attribute EventHandler          ongatheringchange;
             attribute EventHandler          onicechange;
             attribute EventHandler          onidentityresult;
};
//////////////////First Change End//////////////////////////////////////////////

//////////////////Second Change begin///////////////////////////////////////////
///onnegotationneeded->onnegotiationneeded /////of type EventHandler
This event handler, of event handler event type negotiationneeded , must be supported by all objects implementing the RTCPeerConnection interface.
//////////////////Second Change End///////////////////////////////////////////
Comment 1 Anant Narayanan 2012-11-05 02:03:32 UTC
Thanks for the report! Fixed on github and will appear in the next ED.