Bug 19301 - Consistent icon with blog
Summary: Consistent icon with blog
Status: RESOLVED FIXED
Alias: None
Product: webplatform.org
Classification: Unclassified
Component: Comments Extension (show other bugs)
Version: unspecified
Hardware: PC All
: P3 minor
Target Milestone: ---
Assignee: Stefan Widmann
QA Contact: public-webplatform-bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-05 19:33 UTC by Doug Schepers
Modified: 2013-04-01 20:10 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Schepers 2012-10-05 19:33:26 UTC
Can you output the code of the comments icon so we can style it consistently with the blog?

http://blog.webplatform.org/

<div class="comments-link">
 <a href="(something here)">2 comments</a>
</div>
Comment 1 Lea Verou 2012-10-10 22:24:15 UTC
(In reply to comment #0)
> Can you output the code of the comments icon so we can style it consistently
> with the blog?
> 
> http://blog.webplatform.org/
> 
> <div class="comments-link">
>  <a href="(something here)">2 comments</a>
> </div>

Actually, that would result in the same issues as [1]. A better markup would be:

<a href="(something here)" class="comments">
 <span class="count">2</span> comments
</a>

I'm planning to do the same on the blog, once I work on #19453

[1]: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19453
Comment 2 Lea Verou 2012-10-10 22:25:43 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > Can you output the code of the comments icon so we can style it consistently
> > with the blog?
> > 
> > http://blog.webplatform.org/
> > 
> > <div class="comments-link">
> >  <a href="(something here)">2 comments</a>
> > </div>
> 
> Actually, that would result in the same issues as [1]. A better markup would
> be:
> 
> <a href="(something here)" class="comments">
>  <span class="count">2</span> comments
> </a>
> 
> I'm planning to do the same on the blog, once I work on #19453
> 
> [1]: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19453

...or alternatively (and perhaps even better):

<a href="(something here)" class="comments-count">
 2 <span class="comments">comments</span>
</a>
Comment 3 Lea Verou 2012-10-11 00:32:23 UTC
So, after fixing #19453 the markup needed is:

<a href="(whatever)" class="comment-count">
   5
   <span>comments</span>
</a>
Comment 4 Stefan Widmann 2012-10-11 09:40:38 UTC
(In reply to comment #3)
> So, after fixing #19453 the markup needed is:
> 
> <a href="(whatever)" class="comment-count">
>    5
>    <span>comments</span>
> </a>

ok, i think i can do that today, but i don´t know when i´m deploying that, because there are a few minor things to fix. i guess this friday would be okay..
Comment 5 Stefan Widmann 2013-01-09 07:57:40 UTC
(In reply to comment #3)
> So, after fixing #19453 the markup needed is:
> 
> <a href="(whatever)" class="comment-count">
>    5
>    <span>comments</span>
> </a>

deployed to the testing system.
markup is now:
<a id="headId_1" class="comment-count " href="javascript:void(0)">
1
<span class="comments-text">comment</span>
</a>