There are 4 comments (sorted by their types, and the section they are about).
substantive comments
Comment LC-2731
Commenter: Anne van Kesteren <annevk@annevk.nl> (archived message ) Context: 5. Device proximity The HTML5 specification [HTML5] defines...
Status: open
proposal
pending
resolved_yes
resolved_no
resolved_partial
other
assigned to Anssi Kostiainen
Type: substantive
editorial
typo
question
general comment
undefined
Resolution status: Response drafted
Resolution implemented
Reply sent to commenter
Response status:
No response from Commenter yet
Commenter approved disposition
Commenter objected to dispositionCommenter's response (URI):
Comment :Hi,
I would kindly suggest you reorder the requirement for queueing with
the requirement for firing. E.g. "The user agent must queue a task to
fire a device proximity event." (and then remove the requirement for
queueing from the firing steps). This matches phraseology in other
specifications better and allows for reuse of the firing definition in
other contexts.
You defined "ondeviceproximity" and "onuserproximity" twice. This
seems to be because of the legacy-DOM-style formatting.
Do not use RFC 2119 terms in notes, such as "may".
If your device is not doing anything, e.g. completely stationary,
these sensors would theoretically not change and you would never be
able to get the actual state. That might be a mostly academic problem,
but this seems like another set of events that violate the spirit of
DOM Events. Kinda ambivalent on whether that's good or bad, but I
think it at least ought to be pointed out more clearly. And perhaps we
ought to define this more explicitly by having some kind of hook in
addEventListener?
Kind regards,
Related issues: (space separated ids)
WG Notes: http://lists.w3.org/Archives/Public/public-device-apis/2012Dec/0018.html , Changes as per feedback: http://dvcs.w3.org/hg/dap/rev/4c339a6b4b
Resolution: done, see https://dvcs.w3.org/hg/dap/diff/4c339a6b4be4/proximity/Overview.html
reply sent to Anne: http://lists.w3.org/Archives/Public/public-device-apis/2013Jan/0021.html (Please make sure the resolution is adapted for public consumption)
Comment LC-2742
Commenter: Anne van Kesteren <annevk@annevk.nl> (archived message ) Context: 5.2.2 Dictionary DeviceProximityEventInit Members max of t...
Status: open
proposal
pending
resolved_yes
resolved_no
resolved_partial
other
assigned to Anssi Kostiainen
Type: substantive
editorial
typo
question
general comment
undefined
Resolution status: Response drafted
Resolution implemented
Reply sent to commenter
Response status:
No response from Commenter yet
Commenter approved disposition
Commenter objected to dispositionCommenter's response (URI):
Comment :I just noticed your specification has the same issue as the Ambient
thingie. You're not defining default values for the event interface
members. (new UserProximityEvent("haha")).near is undefined. I suggest
adding that to the testsuite. (It's one of the basic things to cover
when testing event constructors.)
Related issues: (space separated ids)
WG Notes: Default values have been added to the editors draft: https://dvcs.w3.org/hg/dap/raw-file/tip/proximity/Overview.html#dictionary-deviceproximityeventinit-members
Resolution: https://dvcs.w3.org/hg/dap/rev/52acb4877e86
reply sent to Anne: http://lists.w3.org/Archives/Public/public-device-apis/2013Jan/0021.html (Please make sure the resolution is adapted for public consumption)
editorial comments
Comment LC-2732
Commenter: Rick Waldron <waldron.rick@gmail.com> (archived message ) Context: 5.2 DeviceProximityEvent Interface [Constructor (DOMString...
Status: open
proposal
pending
resolved_yes
resolved_no
resolved_partial
other
assigned to Anssi Kostiainen
Type: substantive
editorial
typo
question
general comment
undefined
Resolution status: Response drafted
Resolution implemented
Reply sent to commenter
Response status:
No response from Commenter yet
Commenter approved disposition
Commenter objected to dispositionCommenter's response (URI):
Comment :I see the distance measurement unit "in centimeters" is mentioned only
once, in the description of "current device proximity", I would suggest
being explicit and including it in "minimum proximity distance" and
"maximum proximity distance" as well.
Rick
Related issues: (space separated ids)
WG Notes:
Resolution: http://lists.w3.org/Archives/Public/public-device-apis/2012Dec/0014.html
fixed this in the latest Editor's Draft: http://dvcs.w3.org/hg/dap/raw-file/tip/proximity/Overview.html
Diff: http://dvcs.w3.org/hg/dap/rev/c877e2c764b5 (Please make sure the resolution is adapted for public consumption)
Add a comment .