There are 6 comments (sorted by their types, and the section they are about).
question comments
general comment comments
Comment LC-2577
Commenter: Carr, Wayne <wayne.carr@intel.com> (archived message ) Context: 4. BatteryManager Interface [NoInterfaceObject] interface...
Status: open
proposal
pending
resolved_yes
resolved_no
resolved_partial
other
assigned to Nobody
Bah, Slimane
Bernhart, Bryan
Bhaumik, Rijubrata
Bogdanovich, Ilya
Caceres, Marcos
Christiansen, Kenneth
DADAS, Mohammed
Gouaillard, Alexandre
Grant, Reilly
Hazaël-Massieux, Dominique
Hirsch, Frederick
Hu, Ningxin
huang, qigang
Hwang, Dongseong
Jeon, Jonathan
Kang, Shin-Gak
Kim, Sung Hei
Kim, Sunghan
Kinlan, Paul
Kis, Zoltan
Kliche, Ingmar
Kollarova, Martina
Kostiainen, Anssi
Krishnan, Sanjay
Lamouri, Mounir
Lee, Dong-Young
Lee, Kangchan
Lee, Seungyun
Lee, WonSuk
Lin, Wanming
Liu, Dapeng
Liu, Guanyu
Logvinov, Andrey
Mandyam, Giridhar
McCathie Nevile, Charles
Mehrnezhad, Maryam
Mikityuk, Alexandra
Nilsson, Claes
Olejnik, Lukasz
Pashidis, Michallis
Poussa, Sakari
Pozdnyakov, Mikhail
Raggett, Dave
Scheib, Vincent
Shalamov, Alexander
Song, Jungkee
Spreitzer, Raphael
Steglich, Stephan
Stojiljkovic, Aleksandar
Tran, Dzung
Waldron, Rick
Walsh, Michael
WEI, XIAOHAI
xiong, aiden
Xue, Fuqiao
Yamamoto, Eiji
Yamazaki, Fumi
Zhang, Rong
Zhang, Zhiqiang
zhong, heng
Type: substantive
editorial
typo
question
general comment
undefined
Comment :It appears that changes in the Last Call draft have made it so there is no way to distinguish between a full battery and no battery being present. Was the ability to detect a battery being present intentionally removed?
>-----Original Message-----
>From: Dominique Hazael-Massieux [mailto:dom@w3.org]
>Sent: Tuesday, November 29, 2011 8:25 AM
>To: public-device-apis@w3.org
>Cc: public-device-status@w3.org
>Subject: Battery API in Last Call
>
>Hi,
>
>The Battery Status API was published today as a Last Call Working Draft:
>http://www.w3.org/TR/2011/WD-battery-status-20111129/
>
>Please send comments regarding this document to public-device-apis@w3.org ;
>the last call period ends on December 20 2011.
>
>Dom
>
>
Related issues: (space separated ids)
WG Notes:
Proposed Resolution: http://lists.w3.org/Archives/Public/public-device-apis/2012Jan/0020.html (Please make sure the resolution is adapted for public consumption)
substantive comments
Comment LC-2606
Commenter: Marcos Caceres <w3c@marcosc.com> (archived message ) Context: in
Status: open
proposal
pending
resolved_yes
resolved_no
resolved_partial
other
assigned to Anssi Kostiainen
Type: substantive
editorial
typo
question
general comment
undefined
Resolution status: Response drafted
Resolution implemented
Reply sent to commenter
Response status:
No response from Commenter yet
Commenter approved disposition
Commenter objected to dispositionCommenter's response (URI):
Comment :Note that [TreatNonCallableAsNull] is still in flux in WebIDL. I strongly recommend emailing the WebIDL list about this for guidance before proceeding (might save a bit of a headache later).
(...)
the event name is not memorable… bike shed discussion, I know… but the event names are not ideal IMO.
(...)
I'll note that it seems pretty extreme to have four different event registers that basically do the same thing: detecting a change in charge. Why don't you merge them into a "onchange" attribute? Also, the spec says that BatteryManager is an EventHandler, yet no events are fired at it (that seems wrong - event handlers need to have events fired at them)?
Related issues: (space separated ids)
WG Notes: [TreatNonCallableAsNull] (or an equivalent) is required by various handlers in the HTML5 spec and others by both legacy and "new" APIs. My suggestion is we follow the lead and adapt when the dust settles
--
Basically the gist of the design is we don't want to fire unneeded events. Especially on an API that is there to help save same battery.
--
Actually, all the events are fired at the BatteryManager object.
Resolution: Double-checked on WebIDL, no changes. Marcos agreed to the resolution:
http://lists.w3.org/Archives/Public/public-device-apis/2012Apr/0036.html ("Thanks again, and nice work!") (Please make sure the resolution is adapted for public consumption)
Comment LC-2574
Commenter: Anne van Kesteren <annevk@opera.com> (archived message ) Context: 4. BatteryManager Interface [NoInterfaceObject] interface...
Status: open
proposal
pending
resolved_yes
resolved_no
resolved_partial
other
assigned to Anssi Kostiainen
Type: substantive
editorial
typo
question
general comment
undefined
Resolution status: Response drafted
Resolution implemented
Reply sent to commenter
Response status:
No response from Commenter yet
Commenter approved disposition
Commenter objected to dispositionCommenter's response (URI):
Comment :The events need to be queued using the task queue defined in HTML5. It
should probably be worded in such a way that the attribute is updated and
the event is dispatched in the same task so nothing else can observe the
attribute having changed before the event is dispatched.
You also need to actually define the various on* attributes as being event
handlers and update their IDL to match the latest crazy IDL syntax (which
might be simplified, so maybe you want to wait for that).
Should there be some kind of privacy section? I guess you cannot tell much
from someone charging his phone, but maybe in conjunction with other data
you can find patterns of some kind. Fingerprinting is probably also
somewhat aided by this functionality.
Related issues: (space separated ids)
WG Notes: Focus of this issue is on Event handling: queue mechanism and on* attributes. Privacy question is entered as separate issue
Additional comment in response to resolution (1), http://lists.w3.org/Archives/Public/public-device-apis/2012Jan/0006.html :
http://lists.w3.org/Archives/Public/public-device-apis/2012Feb/0023.html
and
http://lists.w3.org/Archives/Public/public-device-apis/2012Feb/0050.html
I think it is okay, but I also think http://dev.w3.org/2009/dap/system-info/battery-status.html#batterymanager-interface could be clearer still. In particular:
* Conformance requirements with respect to the attributes could be merged. E.g. "The attribute must be set to false if the battery is discharging" and "When the battery charging state is updated, the user agent must queue a task which sets the charging attribute's value" would be better if all the requirements where in the latter statement and you would just define the attribute as returning its value.
* In the list of attributes event handler attributes are listed as well, except they are not defined there. They are defined in the next subsection. Somewhat duplicitous if you ask me.
Resolution: (1) http://lists.w3.org/Archives/Public/public-device-apis/2011Dec/0013.html (Please make sure the resolution is adapted for public consumption)
editorial comments
Comment LC-2576
Commenter: Sergiu Dumitriu <sergiu.dumitriu@gmail.com> (archived message ) Context: 4. BatteryManager Interface [NoInterfaceObject] interface...
Status: open
proposal
pending
resolved_yes
resolved_no
resolved_partial
other
assigned to Anssi Kostiainen
Type: substantive
editorial
typo
question
general comment
undefined
Resolution status: Response drafted
Resolution implemented
Reply sent to commenter
Response status:
No response from Commenter yet
Commenter approved disposition
Commenter objected to dispositionCommenter's response (URI):
Comment :An extra editorial comment: in the BatteryManager interface, the level
attribute should be listed after the dischargingTime attribute, to be in
line with the order of their definition, and since it's a more logical
order to keep charging and discharging time together.
Related issues: (space separated ids)
WG Notes:
Resolution: http://lists.w3.org/Archives/Public/public-device-apis/2011Nov/0261.html
Fixed, see:
http://dev.w3.org/2009/dap/system-info/battery-status.html
(Please make sure the resolution is adapted for public consumption)
Comment LC-2580
Commenter: Carr, Wayne <wayne.carr@intel.com> (archived message ) Context: 4. BatteryManager Interface [NoInterfaceObject] interface...
Status: open
proposal
pending
resolved_yes
resolved_no
resolved_partial
other
assigned to Anssi Kostiainen
Type: substantive
editorial
typo
question
general comment
undefined
Resolution status: Response drafted
Resolution implemented
Reply sent to commenter
Response status:
No response from Commenter yet
Commenter approved disposition
Commenter objected to dispositionCommenter's response (URI):
Comment :Separating this from detecting battery presence thread and restating the problem.
Problem with draft: Suppose the battery is full and the user disconnects the power. The battery is now in use and is discharging. The Battery API Last Call draft [1] requires the charging attribute to be set to true, even though the battery is actually discharging. That is an error in the spec.
Current text for charging attribute: "The attribute must be set to false if the battery is discharging, and set to true, if the battery is charging, full, the implementation is unable to report the state, or there is no battery attached to the system, or otherwise.
No exceptions."
Suggested text for charging attribute: "The attribute must be set to false if the battery is discharging, and set to true if the battery is charging. If the implementation is unable to determine the state or there is no battery attached to the system or for any other state not explicitly defined, the attribute must be set to true. No exceptions."
A Boolean probably isn’t the best thing here. Enumeration of {charging, discharging, unknown} is an alternate fix.
[1] http://www.w3.org/TR/battery-status/
Related issues: (space separated ids)
WG Notes:
Resolution: from http://lists.w3.org/Archives/Public/public-device-status/2011Dec/0014.html
Wouldn't dropping "full" from the true condition fix this. "Otherwise" will catch the case "neither charging nor discharging". My proposal:
[[
charging of type boolean, readonly
Represents if the system's battery is charging. The attribute must be set to false if the battery is discharging, and set to true, if the battery is charging, the implementation is unable to report the state, or there is no battery attached to the system, or otherwise.
]]
http://lists.w3.org/Archives/Public/public-device-status/2011Dec/0016.html (Please make sure the resolution is adapted for public consumption)
Add a comment .