This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 5953 - Results entry UI needs revision
Summary: Results entry UI needs revision
Status: RESOLVED FIXED
Alias: None
Product: Test Harness for Browser testing
Classification: Unclassified
Component: CSS Harness (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: fantasai
QA Contact:
URL: http://www.w3.org/2008/07/test-harnes...
Whiteboard:
Keywords:
Depends on: 5958 5959
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-12 20:27 UTC by David Berfanger
Modified: 2008-09-03 22:52 UTC (History)
1 user (show)

See Also:


Attachments
updated template (3.24 KB, text/html)
2008-09-02 17:54 UTC, fantasai
Details
updated template (3.15 KB, text/html)
2008-09-02 19:22 UTC, fantasai
Details
Some suggested changes to the proposed template. (3.28 KB, text/html)
2008-09-02 22:59 UTC, David Berfanger
Details
Updated suggestions for proposed template. (3.33 KB, text/html)
2008-09-03 01:54 UTC, David Berfanger
Details
Yet another updated template proposal (3.24 KB, text/html)
2008-09-03 16:30 UTC, David Berfanger
Details
actual output from revised harness code (3.70 KB, text/html)
2008-09-03 19:23 UTC, David Berfanger
Details

Description David Berfanger 2008-08-12 20:27:09 UTC
The object area containing the actual testcase when entering results is quite small and frequently requires scrolling to view the entire testcase. One the other hand, the metadata above the frame could be made more compact, leaving more room for the testcase.
Comment 1 David Berfanger 2008-09-02 16:44:53 UTC
A proposed redesign has been submitted by fantasai.

This proposed redesign needs to be finalized and implemented.

Fantasai is working out some issues with the proposal, including button placement issues on Firefox and the addition of new buttons (Skip and Not Applicable). Also, fantasai will complete cross browser testing of the proposed interface design.

David Berfanger will then integrate the design in the harness code base.
Comment 2 fantasai 2008-09-02 17:54:34 UTC
Created attachment 565 [details]
updated template
Comment 3 fantasai 2008-09-02 17:56:34 UTC
Tested in FF2, FF3, Opera 9.5, Safari 3.1, IE7
Comment 4 fantasai 2008-09-02 19:22:23 UTC
Created attachment 568 [details]
updated template

Sorry, forgot to validate that. This should work.
Comment 5 David Berfanger 2008-09-02 22:59:36 UTC
Created attachment 570 [details]
Some suggested changes to the proposed template.
Comment 6 David Berfanger 2008-09-02 23:00:26 UTC
1. Rather than having the <a> tags display block, suggesting leaving inline and nest body header info in <p> tags?

2. Rather than selecting "form p + p", which IE seems not to understand; suggesting using "form p.ua"?

3. Should there be a progress counter?, e.g. 
      Test (1 of 511): t170602-bdr-conflict-w-99-d

4. What is the preferred mark-up for multiple notes? Seems like an unordered list would be better than a series of <p class="notes"></p>

new template proposed.



Comment 7 fantasai 2008-09-02 23:30:46 UTC
I left it all in one <p> because to me it reads almost like a sentence or a title.
  W3C CSS 2.1 Conformance Test Suite Test t0602-blah-blah

I don't think the notes really need to be in a list. We could put them in one, but then I'd like the margins and bullets removed and li { display: inline; }
We really want the chrome here to be as compact as possible.

I like the parenthetical progress indicator. I think that's important to add.
Comment 8 David Berfanger 2008-09-03 01:54:42 UTC
Created attachment 572 [details]
Updated suggestions for proposed template.


So, how about? 

1. Leave body header in single paragraph. Maybe use <span> tags to mark-up the various information contained therein?

2. Accept previous suggestion: use selector "form p.ua" rather than "form p + p"

3. Add progress counter to the header info.

4. Mark up multiple notes as a comma separated list in a single <p> block.
Comment 9 David Berfanger 2008-09-03 02:02:18 UTC
Also, we had discussed allowing testers to provide comments.

Is that something that we are still interested in providing?
Comment 10 fantasai 2008-09-03 02:50:00 UTC
1. If the information is already marked up with an <a> then there is no need for a span. We can add classes to <a> as necessary: <span> would just be redundant.

2. Yes.

3. Yes.

4. Comma-separation shouldn't be necessary. Just space separation. Once we have flag->message mappings, the messages should contain the necessary punctuation.
Comment 11 David Berfanger 2008-09-03 16:30:59 UTC
Created attachment 573 [details]
Yet another updated template proposal

(In reply to comment #10)
> 1. If the information is already marked up with an <a> then there is no need
> for a span. We can add classes to <a> as necessary: <span> would just be
> redundant.
> 2. Yes.
> 3. Yes.
> 4. Comma-separation shouldn't be necessary. Just space separation. Once we have
> flag->message mappings, the messages should contain the necessary punctuation.


1. Ok, I preferred not having the progress indicator as part of the hyperlink to the test, but I don't have a strong opinion.

2. Done.

3. Done

4. Done

I'll have the updates checked in and this bug cleared soon.
Comment 12 fantasai 2008-09-03 16:59:17 UTC
1. Ok, yeah, for that case then we need a <span>. :)
Comment 13 fantasai 2008-09-03 17:01:10 UTC
Oh, and if possible we should split out the style sheets for all these templates so they can be tweaked easily. But perhaps that should be a separate bug.
Comment 14 David Berfanger 2008-09-03 19:20:54 UTC
submit.php
  ~ Line 101 & Line 199 -- Added support for the skip button.

testcase.php
  ~ Line 196 -- Changed content title for match proposed template.
  ~ Line >205 
    -- Overwrote previously inherited write_head_style() to provide style
properties of the proposed template
    -- Overwrote previously inherited write_body_header()to match proposed
template.
    -- Altered existing write_body_content() to match proposed template.
    -- Overwrote previously inherited write_body_footer()to match proposed
template.

class.static_page.phi
  ~ Line 185 -- Altered existing write_html() to use new <!DOCTYPE>

class.user_agent.phi
  ~ Line 187 -- Altered construction of the short name of UA to match proposed
template

class.test_flags.phi
  ~ Line 81 -- Altered existing write() to match proposed template

class.test_case.phi
  ~ Line >496 -- Altered existing write() to match proposed template

Fixes are checked in.
Comment 15 David Berfanger 2008-09-03 19:23:34 UTC
Created attachment 574 [details]
actual output from revised harness code

This is the current output from my harness test bed using the current code base as check-in to the CVS repository (2008-09-03 12:22 PST).
Comment 16 fantasai 2008-09-03 22:52:43 UTC
Um, you didn't have to put extra <span>s around *all* of them. Just the one that needed it.