Edit comment LC-2487 for XML Security Working Group

Quick access to LC-2487 LC-2488 LC-2506 LC-2507

Comment LC-2487

Comment Shortname:

Commenter: <Frederick.Hirsch@nokia.com>

Message-id:

Section of the document concerned:

[Free text description]Document as a wholeXML Signature Syntax and Processing Version 2.0 /**/ /... XML Signature Syntax and Processing Version 2.0 W3C Working Draft 21 April 2011 Abstract This document specifies XML digital signature proc... Status of This Document This section describes the status o... Table of Contents 1. Introduction 1.1 XML Signature 2.0 a... 1. Introduction This section is non-normative. This docume... 1.1 XML Signature 2.0 and 1.x compatibility This specificat... 1.2 Editorial and Conformance Conventions For readability,... 1.3 Design Philosophy The design philosophy and requirement... 1.4 Versions Namespaces and Identifiers This specification... 1.5 Acknowledgements The contributions of the members of th... 2. Signature Overview and Examples This section is non-norm... 2.1 Simple XML Signature 2.0 Example This is the same examp... 2.2 Detailed XML Signature 2.0 Example Using Ids The follow... 2.3 Detailed XML Signature 2.0 Example using XPath The foll... 3. Conformance An implementation that conforms to this spec... 3.1 Common Conformance Requirements The following conforman... 3.1.1 General Algorithm Identifier and Implementation Requi... *note: Note that the same URI is used to identify base64 bo... 3.2 XML Signature 2.0 Conformance An implementation that co... 3.2.1 XML Signature 2.0 Algorithm Identifiers and Implement... 3.3 Compatibility Mode Conformance An implementation that c... 3.3.1 Compatibility Mode Algorithm Identifiers and Implemen... **note: The Enveloped Signature transform removes the Signa... 4. Processing Rules The sections below describe the operati... 4.1 Signature Generation The required steps include the gen... 4.2 Reference Generation For each Reference: Decide how to... 4.3 Core Validation The required steps of core validation i... 4.4 Reference Check The absence of arbitrary transforms mak... 4.5 Reference Validation Reference Validation is very simil... 4.6 Signature Validation Signature Validation in XML Signat... 5. Core Signature Syntax The general structure of an XML Si... 5.1 The ds:CryptoBinary Simple Type This specification defi... 5.2 The Signature element The Signature element is the root... 5.3 The SignatureValue Element The SignatureValue element c... 5.4 The SignedInfo Element The structure of SignedInfo incl... 5.4.1 The CanonicalizationMethod Element CanonicalizationMe... 5.4.2 The SignatureMethod Element SignatureMethod is a requ... 5.4.3 The DigestMethod Element DigestMethod is a required e... 5.4.4 The DigestValue Element DigestValue is an element tha... 6. Referencing Content The XML Signature 2.0 specification... 6.1 The Reference Element Reference is an element that may... 6.1.1 The URI Attribute The URI attribute must be omitted f... 6.2 The Transforms Element Each Reference must contain the... 6.3 The dsig2:Selection Element The dsig2:Selection element... 6.3.1 Subtrees with Optional Exclusions Signatures in "2.0... 6.4 The dsig2:Verifications Element dsig2:Verifications is... 7. The KeyInfo Element KeyInfo is an optional element that... binary (ASN.1 DER) X.509 Certificate 7.1 The KeyName Element The KeyName element contains a stri... 7.2 The KeyValue Element The KeyValue element contains a si... 7.2.1 The DSAKeyValue Element Identifier Type="http://www.... http://www.w3.org/2000/09/xmldsig#DSAKeyValue 7.2.2 The RSAKeyValue Element Identifier Type="http://www.... http://www.w3.org/2000/09/xmldsig#RSAKeyValue 7.2.3 The dsig11:ECKeyValue Element Identifier Type=" http... http://www.w3.org/2009/xmldsig11#ECKeyValue 7.2.3.1 Explicit Curve Parameters The dsig11:ECParameters e... 7.2.3.2 Compatibility with RFC 4050 Implementations that ne... 7.3 The RetrievalMethod Element A RetrievalMethod element w... 7.4 The X509Data Element Identifier Type="http://www.w3.or... http://www.w3.org/2000/09/xmldsig#X509Data 7.4.1 Distinguished Name Encoding Rules To encode a disting... 7.5 The PGPData Element Identifier Type="http://www.w3.org... http://www.w3.org/2000/09/xmldsig#PGPData 7.6 The SPKIData Element Identifier Type="http://www.w3.or... http://www.w3.org/2000/09/xmldsig#SPKIData 7.7 The MgmtData Element Identifier Type="http://www.w3.or... http://www.w3.org/2000/09/xmldsig#MgmtData 7.8 XML Encryption EncryptedKey and DerivedKey Elements The... 7.9 The dsig11:DEREncodedKeyValue Element Identifier Type=... http://www.w3.org/2009/xmldsig11#DEREncodedKeyValue 7.10 The dsig11:KeyInfoReference Element A dsig11:KeyInfoRe... 8. The Object Element Identifier Type="http://www.w3.org/2... "http://www.w3.org/2000/09/xmldsig#Object" 9. Additional Signature Syntax This section describes the o... 9.1 The Manifest Element Identifier Type="http://www.w3.or... "http://www.w3.org/2000/09/xmldsig#Manifest" 9.2 The SignatureProperties Element   Identifier Type="htt... http://www.w3.org/2000/09/xmldsig#SignatureProperties 9.3 Processing Instructions in Signature Elements No XML pr... 9.4 Comments in Signature Elements XML comments are not use... 10. Algorithms 10.1 Message Digests This specification def... 10.1 Message Digests This specification defines several pos... 10.1.1 SHA-1 Identifier: http://www.w3.org/2000/09/xmldsig... http://www.w3.org/2000/09/xmldsig#sha1 10.1.2 SHA-256 Identifier: http://www.w3.org/2001/04/xmlen... http://www.w3.org/2001/04/xmlenc#sha256 10.1.3 SHA-384 Identifier: http://www.w3.org/2000/09/xmlds... http://www.w3.org/2000/09/xmldsig#sha384 10.1.4 SHA-512 Identifier: http://www.w3.org/2001/04/xmlen... http://www.w3.org/2001/04/xmlenc#sha512 10.2 Message Authentication Codes MAC algorithms take two i... 10.2.1 HMAC Identifier: http://www.w3.org/2000/09/xmldsig#... http://www.w3.org/2000/09/xmldsig#hmac-sha1 http://www.w3.org/2001/04/xmldsig-more#hmac-sha256 http://www.w3.org/2001/04/xmldsig-more#hmac-sha384 http://www.w3.org/2001/04/xmldsig-more#hmac-sha512 10.3 Signature Algorithms Signature algorithms take two imp... 10.3.1 DSA Identifier: http://www.w3.org/2000/09/xmldsig#d... http://www.w3.org/2000/09/xmldsig#dsa-sha1 http://www.w3.org/2009/xmldsig11#dsa-sha256 Security considerations regarding DSA key sizes 10.3.2 RSA (PKCS#1 v1.5) Identifier: http://www.w3.org/200... http://www.w3.org/2000/09/xmldsig#rsa-sha1 http://www.w3.org/2001/04/xmldsig-more#rsa-sha256 http://www.w3.org/2001/04/xmldsig-more#rsa-sha384 http://www.w3.org/2001/04/xmldsig-more#rsa-sha512 Security considerations regarding RSA key sizes 10.3.3 ECDSA Identifiers: http://www.w3.org/2001/04/xmldsi... http://www.w3.org/2001/04/xmldsig-more#ecdsa-sha1 http://www.w3.org/2001/04/xmldsig-more#ecdsa-sha256 http://www.w3.org/2001/04/xmldsig-more#ecdsa-sha384 http://www.w3.org/2001/04/xmldsig-more#ecdsa-sha512 10.4 Canonicalization Algorithms The input to any canonical... 10.4.1 Canonical XML 2.0 Identifier for Canonical XML 2.0:... 10.5 The Transform Algorithm In XML Signature 2.0, the Tran... 10.6 dsig2:Selection Algorithms 10.6.1 Selection of XML Do... 10.6.1 Selection of XML Documents or Fragments Identifier:... http://www.w3.org/2010/xmldsig2#xml 10.6.1.1 The dsig2:IncludedXPath Element The dsig2:Included... 10.6.1.2 The dsig2:ExcludedXPath Element The dsig2:Excluded... 10.6.1.3 The dsig2:ByteRange Element The dsig2:ByteRange el... 10.6.2 Selection of External Binary Data Identifier: http:... http://www.w3.org/2010/xmldsig2#binaryExternal 10.6.3 Selection of Binary Data within XML Identifier: htt... http://www.w3.org/2010/xmldsig2#binaryfromBase64 10.7 The dsig2:Verification Types 10.7.1 DigestDataLength... 10.7.1 DigestDataLength Identifier: http://www.w3.org/2010... http://www.w3.org/2010/xmldsig2#DigestDataLength 10.7.2 PositionAssertion Identifier: http://www.w3.org/201... http://www.w3.org/2010/xmldsig2#PositionAssertion 10.7.3 IDAttributes Identifier: http://www.w3.org/2010/xml... http://www.w3.org/2010/xmldsig2#IDAttributes 11. XML Canonicalization and Syntax Constraint Consideratio... 11.1 XML 1.0 Syntax Constraints, and Canonicalization XML 1... 11.2 DOM/SAX Processing and Canonicalization In addition to... 11.3 Namespace Context and Portable Signatures In [XPATH] a... 12. Security Considerations The XML Signature specification... 12.1 Transforms A requirement of this specification is to p... 12.1.1 Only What is Signed is Secure First, obviously, sign... 12.1.2 Only What is "Seen" Should be Signed Additionally, t... 12.1.3 "See" What is Signed Just as a user should only sign... 12.2 Check the Security Model This specification uses publi... 12.3 Algorithms, Key Lengths, Certificates, Etc. The streng... 13. Schema 13.1 XSD Schema XML Signature Core Schema Inst... 13.1 XSD Schema XML Signature Core Schema Instance xmldsi... A. Definitions This section is non-normative. Authenticati... Authentication Code Protected Checksum Authentication, Message Authentication, Signer Checksum Core Data Object Integrity Object Resource Signature Signature, Application Signature, Detached Signature, Enveloping Signature, Enveloped Transform Validation, Core Validation, Reference Validation, Signature Validation, Trust/Application B. Compatibility Mode Use of the "Compatibility Mode" desc... B.1 "Compatibility Mode" Examples The following examples ar... B.1.1 Simple Example in "Compatibility Mode" This example u... B.1.2 More on Reference These section explaining the lines... B.1.3 Extended Example (Object and SignatureProperty) This... B.1.4 Extended Example (Object and Manifest) The Manifest e... B.2 Compatibility Mode Processing B.2.1 Reference Generati... B.2.1 Reference Generation in "Compatibility Mode" For each... B.2.2 Reference check in "Compatibility Mode" It is very im... B.2.3 Signature Validation in "Compatibility Mode" Obtain... B.2.4 Reference Validation in "Compatibility Mode" Canonic... B.3 Use of CanonicalizationMethod in "Compatibility Mode" A... NOTE B.4 The URI Attribute in "Compatibility Mode" If the URI at... B.4.1 The "Compatibility Mode" Reference Processing Model N... Note B.4.2 "Compatibility Mode" Same-Document URI-References Der... B.5 "Compatibility Mode" Transforms and Processing Model If... B.6 "Compatibility Mode" Canonicalization Algorithms If can... B.6.1 Canonical XML 1.0 Identifier for required Canonical... B.6.2 Canonical XML 1.1 Identifier for required Canonical... B.6.3 Exclusive XML Canonicalization 1.0 Identifier for Ex... B.7 "Compatibility Mode" Transform Algorithms A Transform a... B.7.1 Canonicalization Any canonicalization algorithm that... B.7.2 Base64 Identifiers: http://www.w3.org/2000/09/xmldsi... http://www.w3.org/2000/09/xmldsig#base64 B.7.3 XPath Filtering Identifier: http://www.w3.org/TR/199... Function: node-set here() B.7.4 Signature Transform Identifier: http://www.w3.org/20... http://www.w3.org/2000/09/xmldsig#enveloped-signature B.7.5 XSLT Transform Identifier: http://www.w3.org/TR/1999... C. References Dated references below are to the latest know... C.1 Normative references [ECC-ALGS] D. McGrew, K. Igoe, M.... [ECC-ALGS] [FIPS-180-3] [FIPS-186-3] [HMAC] [HTTP11] [LDAP-DN] [NFC] [OCSP] [PGP] [PKCS1] [RFC2045] [RFC2119] [RFC3279] [RFC3406] [RFC4051] [RFC4055] [RFC5280] [RFC5480] [SP800-57] [URI] [URN] [URN-OID] [UTF-8] [X509V3] [XML-C14N] [XML-C14N11] [XML-C14N20] [XML-EXC-C14N] [XML-MEDIA-TYPES] [XML-NAMES] [XML10] [XMLDSIG-XPATH] [XMLDSIG-XPATH-FILTER2] [XMLENC-CORE1] [XMLSCHEMA-1] [XMLSCHEMA-2] [XPATH] [XPTR-ELEMENT] [XPTR-FRAMEWORK] [XSL10] [XSLT] C.2 Informative references [ABA-DSIG-GUIDELINES] Digital... [ABA-DSIG-GUIDELINES] [CVE-2009-0217] [DOM-LEVEL-1] [EBXML-MSG] [IEEE1363] [MCINTOSH-WRAP] [RANDOM] [RDF-PRIMER] [RFC4050] [RFC4949] [SAML2-CORE] [SAX] [SHA-1-Analysis] [SHA-1-Collisions] [SOAP12-PART1] [UTF-16] [WS-SECURITY11] [XHTML10] [XML-Japanese] [XMLDSIG-BESTPRACTICES] [XMLDSIG-CORE] [XMLDSIG-REQUIREMENTS] [XMLSEC11-REQS] [XMLSEC2-REQS] [XPTR-XMLNS] [XPTR-XPOINTER] [XPTR-XPOINTER-CR2001]
or

Refinement of the section concerned:

Status:

open proposal pending resolved_yes resolved_no resolved_partial other assigned to Nobody

Type: substantive editorial typo question general comment undefined

Resolution status:

Response drafted Resolution implemented Reply sent to commenter

Response status:

No response from Commenter yet Commenter approved disposition Commenter objected to disposition
Commenter's response (URI):

Comment:

There is an error in the XML Signature 2.0 examples, the dsig2:Selection attribute which specifies the type is named "type" and it should be named "Algorithm" according to the schema ( see http://www.w3.org/TR/2011/WD-xmldsig-core2-20110421/#sec-Selection )

Proposal, change "type='" to "Algorithm=" in the following.

(a) In 2.1, http://www.w3.org/TR/2011/WD-xmldsig-core2-20110421/#sec-o-Simple-2.0

[s07a] <dsig2:Selection type="http://www.w3.org/2010/xmldsig2#xml" xmlns:dsig2="http://www.w3.org/2010/xmldsig2#"
URI="http://www.w3.org/TR/2000/REC-xhtml1-20000126">

(b) In 2.2, http://www.w3.org/TR/2011/WD-xmldsig-core2-20110421/#sec-DetailedIdExample-2.0

[ i23 ] <dsig2:Selection type="http://www.w3.org/2010/xmldsig2#xml" URI="#MsgBody" />

(c) and in 2.3, http://www.w3.org/TR/2011/WD-xmldsig-core2-20110421/#sec-DetailedXPathExample-2.0

[ p24 ] <dsig2:Selection type="http://www.w3.org/2010/xmldsig2#xml" URI="">


regards, Frederick

Frederick Hirsch
Nokia


xs:element name="Selection" type="dsig2:SelectionType"/>
<xs:complexType name="dsig2:SelectionType">
<xs:sequence>
<xs:any namespace="##any" processContents="lax" minOccurs="0" maxOccurs="unbounded"/>
</xs:sequence>
<xs:attribute name="URI" type="xs:anyURI" use="required"/>
<xs:attribute name="Algorithm" type="xs:anyURI" use="required"/>
</xs:complexType>

Related issues: (space separated ids)

WG Notes:

Resolution: Fixed, http://lists.w3.org/Archives/Public/public-xmlsec/2011Sep/0013.html

(Please make sure the resolution is adapted for public consumption)