Re: DAP-ACTION-730: Ask zhiqiang to update the battery test suite to match latest battery spec (coordinating with marcos)

Hi All,

[...]

>>> * [FAIL] battery-plugging-in-manual.html
> 
> [For the reference:]
> 
>  http://www.w3c-test.org/battery-status/battery-plugging-in-manual.html
> 
>>> 3 Pass, 1 Fail
>>> 
>>> - 1 test fails with the message: assert_equals: The value of the
>>> dischargingTime attribute must be set to Infinity. expected Infinity but got
>>> 10380
>>> 
>>> This seem to be a bug in the implementation, that is in conflict with the
>>> following assertion in the CR spec:
>>> 
>>> [[
>>> 
>>> The dischargingTime attribute must be set to the value positive Infinity, if the
>>> battery is charging
>>> 
>>> http://www.w3.org/TR/2014/CR-battery-status-20141209/#widl-
>>> BatteryManager-dischargingTime
>>> 
>>> ]]
>>> 
>>> Zhiqiang - correct? If my hunch is correct, we should file a bug against the
>>> implementation and find someone to fix it.
>> 
>> Yes, you are right. Since I have no OS X environment, please help file the bug, thanks.
> 
> I've identified an Intel contributor who was interested in fixing this soon. We'll report back when the fix has landed.

It appears Chrome 43.0.2315.0 Canary (64-bit), as well as Chromium tip of tree pass all the 4 tests now, so we can declare:

[PASS] battery-plugging-in-manual.html

We had a look at the tip of the tree diff to Stable, but were unable to identify the root cause for the failure in Stable. Anyway, the tests pass now, so we're good.

Note to self: I should not have tested with Stable, even if no substantial changes went in in between.

>>> A reasonable plan forward might be to:
>>> 
>>> * investigate the reasons for test failures on known implementations

Done.

>>> * address the assumed implementation bugs

Fixed in Chrome Canary.

>>> * assess the impact on the spec progress: a precondition to exit CR would be
>>> to get two implementations, for example, if the Chrome bugs
>>> (http://crbug.com/43394, others?) are fixed, and Mozilla updates its
>>> implementation (https://bugzil.la/1047119)

The remaining implementation issues blocking CR exit are

* Chrome's lack of WebIDL compliance (http://crbug.com/43394) that causes the battery-interface-idlharness.html and battery-interface.html tests to fail.

* Mozilla's implementation update to match the latest spec (https://bugzil.la/1047119).

>> Good plan. Let's move forward together.
> 
> Btw. the Chrome Android bug of missing an implementation of chargingTime and dischargingTime attributes has been fixed couple of days ago, see:
> 
>  https://crbug.com/401553
> 
> Zhiqiang - you may want to rerun the relevant tests on a fresh Android build.

Zhiqiang - please let us know the results from Android when you're able to test with a new build.

Thanks,

-Anssi

Received on Thursday, 26 February 2015 10:03:15 UTC