Re: at-supports-014 out of date

On Friday 2013-05-31 14:20 +0200, Florian Rivoal wrote:
> On Fri, May 31, 2013, at 11:27, L. David Baron wrote:
> > The test
> > contributors/opera/submitted/css3-conditional/at-supports-014.html
> > is out of date based on the working group resolution committed in
> > this changeset: https://dvcs.w3.org/hg/csswg/rev/34b185ae3bac
> > 
> > The attached patch should, I believe, turn it into a correct test.
> > If you agree that this is correct, feel free to commit it (and
> > preferably let me know), or ask me to commit it.
> 
> The change you propose would indeed correct to match this resolution,
> but would also make the test appear to pass on an implementation
> which does not have @supports at all. My understanding is that we
> try to avoid this kind of false positives.
> 
> As an alternative, I'd propose reverting to an earlier version
> of the same test which did also require the presence of a space:
> 
> http://hg.csswg.org/test/file/5f94e4b03ed9/contributors/opera/submitted/css3-conditional/at-supports-014.html

Indeed, that's better.

-David

-- 
𝄞   L. David Baron                         http://dbaron.org/   𝄂
𝄢   Mozilla                           http://www.mozilla.org/   𝄂

Received on Friday, 31 May 2013 12:58:41 UTC