Talk:SC1-1-1-css-image

Open issues

• What does the following mean exactly? : Retrieve the text from its child nodes of type text or containing text before or after the selected element

Wilco Fiers (talk) 13:56, 14 October 2015 (UTC)

Ready for review

• What about image sprites? - should be covered as all CSS-styles are applied to the presented item. also the background-position

Twan van Houtum (talk) 13:33, 3 September 2015 (UTC)

• Step 1: What about "backgroundRepeat: inherit"? In the current logic this passes the test. - now checking for the computed backgroundRepeat property
• Step 3: I think we need to be a bit more specific about what is presented to the user. For example, if the element with the css background image also contains an <img> element. The images must be presented in such a way that a user (without html knowledge) can distinguish foreground and background images. - steps 3 and 4 updated by preparation of the element

Annika Nietzio (talk) 14:02, 6 August 2015 (UTC)

Closed issues

• Can step 3 and 4 be merged? - Done

--Kamyar Rasta (talk) 13:53, 2 July 2015 (UTC)

• I don't quite understand the following sentence "Retrieve the text from its child nodes of type text or containing text before or after the selected element and assign it to variable T1" - Clarified in last Call?

Wilco Fiers (talk) 13:39, 2 July 2015 (UTC)

• Step 4 has no description. - Added
• Step 5 user interaction should be 'no' instead of 'yes'. -Not changed, explanation below

Twan van Houtum (talk) 11:35, 2 July 2015 (UTC)

• The comment on step 5 raises the question, if in this SC we should check for functionality of the elements ("Otherwise, or if the element provides any functionality..."). In AngularJS for example, it is possible to add events to any element, such as div or span.

Frank Berker (talk) 12:07, 2 July 2015 (UTC)

• Step 5: T1 should be presented to the user. - Done

Annika Nietzio (talk) 13:30, 17 June 2015 (UTC)

• "Element containing background images positioned and in same order as defined by CSS" I'm not sure I understand what's going on here -Changed

Wilco Fiers (talk) 13:26, 17 June 2015 (UTC)

• Description: Added check for description provided in text nearby.
• Step 4: removed "eyecatching" from help-text
• Step 4: changed to context-sensitive
• Step 5: Introduced variable T1 used in user input question
• Step 4 and 5: aligned item presented to the user

Frank Berker (talk) 09:02, 17 June 2015 (UTC)

• Helptext sums up use cases we should be able to automatically determine, namely:
  • spacers
  • lines
  • menu-backgrounds
• And can css background images be used as spacers? - - changed "spacers" in step 4 to "separator"

Hanno Lans (talk) 14:28, 16 June 2015 (UTC)

• Fix numbering of result identifiers: pass1, pass2, ...

Annika Nietzio (talk) 13:57, 7 May 2015 (UTC)

• I don't think we should be referring to the DOM. If this is somehow important (and I think it is) we should present the text available in the nearby DOM structure to the user instead.

Wilco Fiers (talk) 13:49, 7 May 2015 (UTC)

• note that since css3 multiple are possible: http://www.css3.info/preview/multiple-backgrounds/
  • does that mean that both images have to be presented? does the JS-selector return an array? --Frank Berker (talk)
  • tried to consider multiple images

Frank Berker (talk) 11:04, 28 April 2015 (UTC)

• I think it's worth including a step 5 to test if the text alternative is somewhere adjecent to the image.

Wilco Fiers (talk) 13:36, 30 April 2015 (UTC)

• additional test: test if the image is covered with text above the image (a text box covering the area from left to right) -> we can assume the image is decorative

--Hanno Lans (talk) 16:18, 30 October 2014 (UTC)

• Step 1 checks the background-repeat property. Do we also need to check the background property?
  

Twan van Houtum (talk) 9:03, 30 April 2015 (UTC)

• test if a image is used to convey information by color or shape, can be dealt with SC1-4-1 and SC1-3-3

--Hanno Lans (talk) 16:18, 30 October 2014 (UTC)

• should we take care about iconfonts?
  • I will try to handle this in SC1-1-1-character-based-non-textual --Frank Berker (talk)

--Hanno Lans (talk) 14:58, 30 October 2014 (UTC)

• Selector: Include "list-style" shorthand for completeness.
• Step 2: I think we need an explanation for "surrounding text".
  • added surrounding_text to the wiki with a citation from WCAG2.0 --Frank Berker (talk)

--Annika Nietzio (talk) 13:28, 30 October 2014 (UTC)

• I like the javascript expression. Keep it
• The :before and :after pseudo-selectors are a big subject all on their own, and one that is relevant to other criteria as well. It's part of a bigger question of what to do with shadow DOM
• I would prefer if we could capture this test in a single question, has this been tried yet?
• Step 2: What is 'surrounding text'? Is a user supposed to locate this text on the page? What about hidden text? Should we instead pull the surrounding text from the page and ask the user to compare that, so that we can include any AT-only text?
  • removed Step 2 since it didn't fit to that test - copy and paste error --Frank Berker (talk)

Wilco Fiers (talk) 13:55, 30 October 2014 (UTC)

• it's now manual testing only, I would like to see some automatic tests at the start. Two suggestions:
• we can assume that as soon as background-repeat is used, it's decorative
  • included --Frank Berker (talk)
• we can assume that as soon the image is less than 10 pixels width or height, it's decorative
  • limited the size to 5 * 3 px, because this is the smallest room for readable characters --Frank Berker (talk)

--Hanno Lans (talk) 14:58, 30 October 2014 (UTC)