This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 25977 - DTMFSender should have an onerror event handler
Summary: DTMFSender should have an onerror event handler
Status: RESOLVED WONTFIX
Alias: None
Product: WebRTC Working Group
Classification: Unclassified
Component: WebRTC API (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: Web RTC Working Group
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-04 09:33 UTC by Kiran
Modified: 2014-06-11 07:19 UTC (History)
3 users (show)

See Also:

Attachments

Description Kiran 2014-06-04 09:33:44 UTC 
Errors on a DTMFSender need to be reported through an error event, say DTMFError.

1. Invalid DTMF values
2. Values of duration and interToneGap with out of range values.
Comment 1 Justin Uberti 2014-06-04 18:28:52 UTC 
Shouldn't those throw an exception? Those can be easily detected synchronously.
Comment 2 Kiran 2014-06-05 09:47:15 UTC 
(In reply to Justin Uberti from comment #1)
> Shouldn't those throw an exception? Those can be easily detected
> synchronously.

I agree that duration and interToneGap ranges can be detected and thrown as exceptions.

But onerror seems still required for reporting error in case of inserting invalid DTMF values [1], Bug: 25837. 

[1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=25837
Comment 3 Justin Uberti 2014-06-05 17:46:05 UTC 
It's not required - we could parse the string synchronously and return an error, which would be nicer than playing out some tones and then stopping with an error.
Comment 4 Adam Bergkvist 2014-06-11 07:19:43 UTC 
(In reply to Kiran from comment #0)
> 1. Invalid DTMF values

Updated insertDTMF() algorithm to ignore unrecognized characters. Proposed fix [1] 

> 2. Values of duration and interToneGap with out of range values.

This was fixed in [2].


Closing this bug as WONTFIX.

[1] https://github.com/fluffy/webrtc-w3c/commit/d58a8bcf7ac4998dea3f670ccd278ce1c0b6c89e
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=25976