Meeting minutes
https://github.com/w3c/aria-practices/milestone/2
Matt_King: Looks like cutoff for getting items merged is tomorrow morning.
https://
Matt_King: I have items listed in order
https://github.com/w3c/aria-practices/pull/1895
Matt_King: looks like this is updated, correct Jon?
jongund: yes, I updated CSS
https://github.com/w3c/aria-practices/pull/1869
Matt_King: Howard were you looking on this tree view?
howard_edwards: No, it was Simon and Z
Matt_King: Sara are you available to help out with this one? To make sure when the page loads we have aria selected false specified by default
sarah_higley: I have a few other things but what would I be looking at?
<Matt_King> preview tree: https://
Matt_King: when the page loads nothing is selected, so everything should be set to false
sarah_higley: yes, I can look at that.
Matt_King: the tree is currently named file viewer but it is not. It is a file viewer I suggested selected folder or file. I was considering the word selected.
sarah_higley: what about My Documents
Matt_King: we can use My Documents as a label.
sarah_higley: my suggestion is to have a visual selection state.
sarah_higley: we do not have one
Matt_King: that is not good and should be on the fix list.
Boaz: Z came on for a week to provide lift and Howard should be working on it.
Matt_King: should we use same indicator in My Documents tree view?
howard_edwards: yes that is something we can do
Matt_King: I assume we have a nice focus indicator in the tree.
howard_edwards: I have that noted
Matt_King: we have the enter key performing two actions: expanding and selecting. I don't think we should be doing that.
sarah_higley: I think it depends on context alot. enter and space are less keyboard savy.
Matt_King: it would complicate the conversation on what is selectable
Matt_King: it would bring a lot of changes to this example
Matt_King: would avoid making changes before we try to get it out the door.
sarah_higley: in this context it makes sense for enter to select
Matt_King: I don't want to overload and set up something problematic
Matt_King: what about the name of the edit field?
sarah_higley: realistically we wouldn't have a text field
Matt_King: hopefully not unrealistic to change and test by tomorrow. Will need assistance checking the high contrast. Jemma or Jon can you assist?
jongund: yes, I will be around tomorrow.
howard_edwards: i should be able to take a look at this.
siri: Matt why do you say performing two actions is too much.
<Jemma> summary of the work to be done - https://
Matt_King: I am concerned that someone might implement a real tree by mimicking the two behaviors to be distinct.
Matt_King: I wanted to align the example with the pattern and we can work on the pattern in the future.
https://github.com/w3c/aria-practices/pull/1870
Matt_King: we had some editorial stuff that we cleared up
jongund: i added aria label to the regression test
Matt_King: I want to check that we are good with pointer behavior
jongund: I found with other rating systems once you hover over it selects to the stars and then when you click it sets.
Matt_King: using the keyboard it is changing the value of the input. with hover it looks like you have changed the value but you have not changed it. I don't know how that might that effect magnifiers and cause confusion.
bryan: I do know if impacts focusability
Matt_King: i am concerned about the mag users and they won't be able to see it without moving their mouse.
jongund: we can take the hover state out so hover does not change any styling.
Matt_King: Sara, does my concern make sense.
sarah_higley: yes it does, there is a side benefit to see a preview of what the change might be. I think a change should be a later thing.
Matt_King: do you have time to make the update that before that middle of tomorrow?
jongund: yes, code might not be clean but behavior should work.
https://github.com/w3c/aria-practices/pull/1876
jongund: we can't test high contrast due to an issue in Chrome. It seems to work on FF and I can check on Safari. It appears that it should work.
jongund: I will update my review
Matt_King: if you update your review I will do a final look through and this might be reviewable today.
topic: https://github.com/w3c/aria-practices/pull/2112
Matt_King: we don't have aria described by pointing to that message
Matt_King: aria-controls is not desirable on a button that is bringing up an issue. so if you remove it the javascript breaks?
howard_edwards: yes, pretty much
Matt_King: i think we should correct that. Is there anyone available?
jongund: I can look at that.
sarah_higley: I see what it is, line 175. I can do that now if you like.
Matt_King: let us just fix the controls
https://github.com/w3c/aria-practices/pull/1834
Matt_King: there are checks failing
sarah_higley: I have not finished the tests yet.
Matt_King: there are still some pending reviewers
Jemma: I am a still adding myself for general accessibility review
Matt_King: It might be a stretch to get in but will see what flexibility Michael has.
https://github.com/w3c/aria-practices/pull/2121
Matt_King: this is in draft and it would be good to have people review. Other eyes on it to make sure I did not make mistakes.
jongund: I will take a look at it.