This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 9955 - XQuery/Modules/ModuleImportModules/ModuleImport/modules-19.xq through modules-28.xq
Summary: XQuery/Modules/ModuleImportModules/ModuleImport/modules-19.xq through modules...
Status: CLOSED FIXED
Alias: None
Product: XML Query Test Suite
Classification: Unclassified
Component: XML Query Test Suite (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal
Target Milestone: ---
Assignee: Sorin Nasoi
QA Contact: Mailing list for public feedback on specs from XSL and XML Query WGs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-19 16:14 UTC by Sorin Nasoi
Modified: 2010-06-22 15:26 UTC (History)
1 user (show)

See Also:


Attachments

Description Sorin Nasoi 2010-06-19 16:14:45 UTC
There is an error in the cat/ModuleImport.xml for tests modules-19.xq through modules-28.xq:

instead of 
<module namespace="http://www.w3.org/TestModules/defs">module3-lib</module>
it should be
<module namespace="http://www.w3.org/TestModules/defs">module-defs</module>
Comment 1 Sorin Nasoi 2010-06-19 16:33:27 UTC
I have committed a fix today for tests modules-19.xq through modules-27.xq
modules-28.xq seems to be correct.
Comment 2 Oliver Hallam 2010-06-21 10:46:20 UTC
Your fix seems to have broken all these tests.

The tests all import a module with namespace 'http://www.w3.org/TestModules/test1'

Firstly, the purpose of these tests was to test the errors that occur when importing modules with schema types, yet module-defs does not have any schema types, so module3-lib was definitely the correct module to import.

Secondly, module-defs imports a module with namespace "http://www.w3.org/TestModules/test1", yet no <module> declaration exists for this module.
Comment 3 Sorin Nasoi 2010-06-22 06:55:04 UTC
Hi,
all the tests I mentioned (modules-19.xq through modules-27.xq) import module defs with namespace "http://www.w3.org/TestModules/defs.

If you check out the module moduleDefs-lib written by Carmelo Montanez you will see that it import a library module test1 with namespace "http://www.w3.org/TestModules/test1".

I agree that the fix is wrong, I will fix them today, but initially the tests were wrong: the main module module-3.lib defines the namespace "http://www.w3.org/TestModules/defs" which is the same as the namespace for module moduleDefs-lib. This creates a break when you try to process XQTS, the namespaces of the modules should be unique.

The correct fix would be to:
- change the namespace of module3-lib to something like "http://www.w3.org/TestModules/module3" and then in the tests import module3-lib with this namespace.
Comment 4 Sorin Nasoi 2010-06-22 07:09:48 UTC
I have just committed a new fix.
Comment 5 Oliver Hallam 2010-06-22 15:26:55 UTC
I don't think it is a requirement for modules in the catalog to all have distinct URIs, but keeping them distinct can only be a good thing.  

I agree with your fix so I will mark the bug CLOSED (since you have already indicated that this resolves your problem).