This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 7793 - white space bugs in expected results
Summary: white space bugs in expected results
Status: RESOLVED FIXED
Alias: None
Product: XQuery Update Facility Test Suite
Classification: Unclassified
Component: XQuery Update Facility Test Suite (show other bugs)
Version: 1.0.0
Hardware: PC Linux
: P1 major
Target Milestone: ---
Assignee: Michael Kay
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-02 09:10 UTC by Markos Zaharioudakis
Modified: 2009-11-06 00:19 UTC (History)
1 user (show)

See Also:


Attachments

Description Markos Zaharioudakis 2009-10-02 09:10:46 UTC
There are several bugs concerning whitespace in the expected results of XQUTS. Here is the list:

valskip-repnode-005
valskip-repnode-006
removeType-valskip-repnode-006
removeType-valskip-repnode-005
Expected result contains newlines and indentation that should not be there.


valskip-ins-013
removeType-valskip-ins-013
There is an extra indentation space in front of <a>, <b>, and <c>.
There is a missing space right after </c>.
The PRICE element should not be in a new line by itself.


vallax-ren-003
revalidate-vallax-ren-003
There is an extra indentation space in front of <a>, <b>, <c>, and <d>.
There is a missing space right after </c>.


valstrict-del-002
valstrict-del-004
valstrict-ins-003
revalidate-valstrict-del-002
revalidate-valstrict-del-004
revalidate-valstrict-ins-003
There is an extra indentation space in front of <a>, <b>, <c>, <d>, and <e>.
There is a missing space right after </c>.
There are 3 missing spaces right after </e>.


valstrict-ren-003
valstrict-repnode-003
revalidate-valstrict-ren-003
revalidate-valstrict-repnode-003
There is an extra indentation space in front of <a>, <b>, <c>, and <d>.
There is a missing space right after </c>.


valstrict-ins-005
revalidate-valstrict-ins-005
There is an extra indentation space in front of <a>, <b>, <c>, <d>, <e>, and <f>.
There is a missing space right after </c>.
There are 3 missing spaces right after </e>.
There are 5 missing spaces right after </f>.


valstrict-ins-007
revalidate-valstrict-ins-007
There is an extra indentation space in front of <a>, <b>, <c>, <d>, <e>, <f>, and <g>.
There is a missing space right after </c>.
There are 3 missing spaces right after </e>.
There are 5 missing spaces right after </f>.
There are 7 missing spaces right after </g>.


valtrans-ins-002
revalidate-valtrans-ins-002
The new author ("Thursday Next") should appear in the same line as the previous author ("Jane Austen").
TITLE element should appear in a line by itself
<?pi data?> should appear in a line by itself
<!-- the first book --> should appear in a line by itself
Comment 1 Michael Kay 2009-11-05 11:53:51 UTC
I agree with you - these results have been incorrectly formatted (using indent="yes" on the serializer). I'll work to fix them.

I'm puzzled by two things, however.

* Firstly, your list seems very incomplete. As far as I can see it affects all the tests in these groups. Did you intend the list to be complete?

* Secondly, your detailed analysis sometimes seems wrong. For example, for valskip-ins-013 you say "There is a missing space right after </c>". But as far as I can see, if the test is run without indenting output, there will be no space after </c>.

Michael Kay
Comment 2 Michael Kay 2009-11-05 14:26:03 UTC
I have regenerated the results with indent="no" omit-xml-declaration="yes", so I believe the problem is now fixed, and am closing the bug accordingly.
Comment 3 Michael Kay 2009-11-05 14:26:41 UTC
I have regenerated the results with indent="no" omit-xml-declaration="yes", so I believe the problem is now fixed, and am closing the bug accordingly.
Comment 4 Markos Zaharioudakis 2009-11-05 22:29:11 UTC
(In reply to comment #3)
> I have regenerated the results with indent="no" omit-xml-declaration="yes", so
> I believe the problem is now fixed, and am closing the bug accordingly.
> 

Thanks for looking into this. I have one more question: the new results will be generated with indent="no" AND with the boundary whitespace mode set to "strip", right?

By the way, it seems that the XQUTS_1_0_0.zip file at http://dev.w3.org/2007/xquery-update-10-test-suite/ has not been updated with the new results yet, right?
Comment 5 Michael Kay 2009-11-06 00:19:48 UTC
>I have one more question: the new results will be
generated with indent="no" AND with the boundary whitespace mode set to
"strip", right?

In effect yes. I generated the results using Saxon which has boundary whitespace set to "strip" by default, as recommended in the XQuery spec. This is the required setting for XQuery tests unless specified otherwise.


>By the way, it seems that the XQUTS_1_0_0.zip file at
http://dev.w3.org/2007/xquery-update-10-test-suite/ has not been updated with
the new results yet, right?

Correct. I've only fixed the tests in CVS. I don't know what the plans are for generating a new versioned ZIP archive.

Michael Kay