This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 6934 - Comments occur before the version declaration in test cases
Summary: Comments occur before the version declaration in test cases
Status: CLOSED FIXED
Alias: None
Product: XML Query Test Suite
Classification: Unclassified
Component: XML Query Test Suite (show other bugs)
Version: 1.0.2
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: Frans Englich
QA Contact: Mailing list for public feedback on specs from XSL and XML Query WGs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-20 16:39 UTC by Josh Spiegel
Modified: 2009-10-14 16:09 UTC (History)
2 users (show)

See Also:

Attachments

Description Josh Spiegel 2009-05-20 16:39:12 UTC 
In many test cases (e.g. K-VersionProlog-1) comments occur before the version declaration.  This seems to be contrary to the XQuery specification:

"If a version declaration is present, no Comment may occur before the end of the version declaration. If such a Comment is present, the result is implementation-dependent."

see http://www.w3.org/TR/xquery/#id-version-declaration, section 4.1, 4th paragraph.  

In our implementation, we will raise an error in such cases.
Comment 1 Michael Kay 2009-05-21 06:54:57 UTC 
Any chance you could enumerate the test cases concerned?
Comment 2 Josh Spiegel 2009-05-21 17:11:05 UTC 
Here are tests I found in ./XQTS/Queries/XQuery/ which have comments before a version declaration:

 Expressions/PrologExpr/VersionProlog/K-VersionProlog-1.xq
 Expressions/PrologExpr/VersionProlog/K-VersionProlog-2.xq
 Expressions/PrologExpr/VersionProlog/K-VersionProlog-3.xq
 Expressions/PrologExpr/VersionProlog/K-VersionProlog-4.xq
 Expressions/PrologExpr/VersionProlog/K-VersionProlog-5.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-001.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-002.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-003.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-004.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-006.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-007.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-008.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-009.xq
 Expressions/PrologExpr/VersionProlog/version_declaration-010.xq
 SchemaImport/versionPrologSI/version_declaration-005.xq

Here are tests I found in ./XQTS/Queries/XQuery/ which have a version declaration without preceding comments:

 Expressions/PrologExpr/VersionProlog/prolog-version-1.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-10.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-11.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-12.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-3.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-4.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-5.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-6.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-7.xq
 Expressions/PrologExpr/VersionProlog/prolog-version-9.xq
 SchemaImport/versionPrologSI/prolog-version-8.xq
Comment 3 Michael Kay 2009-05-21 17:36:29 UTC 
I think the author of the test in many/most of these cases probably didn't intend the comment to appear before the version declaration. However, the expected test results in most cases do seem to allow an error to be reported, so it's not clear to me that the expected results are incorrect for these tests.
Comment 4 Josh Spiegel 2009-05-21 18:58:34 UTC 
First of all, thank you Dr. Kay for your quick attention to this issue.  

It is my understanding that of the 15 tests I listed, only version_declaration-001,002,003,004 will pass with any error.  The remaining 11 tests either expect a specific error or no error at all.  In other words, our implementation that throws an error when comments occur before the declaration will fail the 11 tests when it should not.  Forgive me if this is incorrect.
Comment 5 Frans Englich 2009-10-14 14:17:42 UTC 
Those 15 tests should now be fixed to have the version declaration in the beginning. Might be I missed something.
Comment 6 Josh Spiegel 2009-10-14 16:09:13 UTC 
Verified.  Thanks!