This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 674 - missing necessary implementationAttribute in LS test entities08
Summary: missing necessary implementationAttribute in LS test entities08
Status: RESOLVED FIXED
Alias: None
Product: DOM TS
Classification: Unclassified
Component: DOM Level 3 (show other bugs)
Version: unspecified
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: Philippe Le Hegaret
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-15 16:23 UTC by nnissar
Modified: 2004-05-08 06:36 UTC (History)
0 users

See Also:


Attachments
Now adds an entity reference if expected one is not in document (1.58 KB, patch)
2004-05-07 22:45 UTC, Curt Arnold
Details
Patch that should have been attached to bug 673 (35.50 KB, patch)
2004-05-08 02:36 UTC, Curt Arnold
Details

Description nnissar 2004-04-15 16:23:58 UTC
LS test entities08 checks to see that entity references are preserved upon 
serialization when entities is true.  However when the document (that is later 
serialized) is initially loaded, entity reference nodes are being expanded.  By 
setting the 'expandEntityReferences' implementationAttribute to 'false', this 
problem can be solved.


Patch to LS test entities08.xml:

+ <implementationAttribute name="expandEntityReferences" value="false"/>
<var name="doc" type="Document"/>
<var name="domConfig" type="DOMConfiguration"/>
<var name="domImplLS" type="DOMImplementationLS"/>
<var name="lsSerializer" type="LSSerializer"/>
<var name="output" type="DOMString"/>
<implementation var="domImplLS"/>
<load var="doc" href="hc_staff" willBeModified="true"/>
Comment 1 Curt Arnold 2004-05-07 22:44:49 UTC
The observation is valid, the test will fail as written if entity references are
expanded on load.  I've taken another tack and modified the code so that it adds
an entity reference after load if there isn't one in the test.  Otherwise, a
hypothetical implementation that supported L3 L&S but didn't support toggling
entity expansion through the framework would still have a test for this behavior.
Comment 2 Curt Arnold 2004-05-07 22:45:24 UTC
Created attachment 359 [details]
Now adds an entity reference if expected one is not in document
Comment 3 Curt Arnold 2004-05-08 02:36:38 UTC
Created attachment 360 [details]
Patch that should have been attached to bug 673