This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 5684 - [XQTS] some FunctX timezone test depend on context timezone
Summary: [XQTS] some FunctX timezone test depend on context timezone
Status: RESOLVED FIXED
Alias: None
Product: XML Query Test Suite
Classification: Unclassified
Component: XML Query Test Suite (show other bugs)
Version: unspecified
Hardware: PC Windows NT
: P2 normal
Target Milestone: ---
Assignee: Frans Englich
QA Contact: Mailing list for public feedback on specs from XSL and XML Query WGs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-13 11:17 UTC by Oliver Hallam
Modified: 2008-06-26 14:09 UTC (History)
0 users

See Also:


Attachments

Description Oliver Hallam 2008-05-13 11:17:11 UTC
The following FunctX tests only work when the static timezone is +02:00 (although the results on the FunctX website are given for an implicit timezone of -05:00)

functx-fn-adjust-dateTime-to-timezone-6
functx-fn-adjust-dateTime-to-timezone-7
functx-fn-adjust-dateTime-to-timezone-all
functx-fn-adjust-date-to-timezone-5
functx-fn-adjust-date-to-timezone-6
functx-fn-adjust-date-to-timezone-all
functx-fn-adjust-time-to-timezone-5
functx-fn-adjust-time-to-timezone-6
functx-fn-adjust-time-to-timezone-7
functx-fn-adjust-time-to-timezone-8
functx-fn-adjust-time-to-timezone-all
functx-fn-implicit-timezone-1

I can think of 4 possible solutions:
1) Rewrite the adjust tests to compare the timezone with implicit-timezone(), and drop the implicit-timezone-1 test; although this will be quite messy in some cases and loose the succinctness of the tests.
2) Specify that the entire test suite should be run in a particular timezone (eg. +02:00).
3) Add another element/attribute/role to the test-cases to specify the timezone in which a test must be run.  This is my preferred solution.
4) Remove these tests entirely.
Comment 1 Andrew Eisenberg 2008-05-15 20:02:32 UTC
We ran into this issue long ago. My recollection is that agreed to use explicit timezones in most of our test cases, and to use Z as the expected value of the implicit timezone in just a small number of the test cases.

Perhaps I recall wrongly, or perhaps we changed this over time. I went looking for precedent, and found that in fn-implicit-timezone-2 that we expect "-PT5H" and the comparator is Inspect.

Comment 2 Frans Englich 2008-05-16 07:37:50 UTC
Anyhow, it needs fixing.

I didn't have the measures for reviewing each test individually -- things like this will crop, but I believe it will be relatively few issues.
Comment 3 Frans Englich 2008-06-25 16:35:20 UTC
I've tried to fix this in CVS. These files are generated and it's not the easiest thing to get an overview of so it's very likely I've missed something here.
Comment 4 Oliver Hallam 2008-06-26 13:50:48 UTC
These tests have all been removed/fixed correctly, with the exception of the expected result for functx-fn-adjust-time-to-timezone-all.
Comment 5 Frans Englich 2008-06-26 14:09:59 UTC
Yeah, updated version in CVS, I hope it's right.