This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.
1. dom-to-dtd.xsl should allow comments anywhere in the test function body. I need to keep a list of ints in a List and iterate over the values. To do this, I added a subtype attribute to <var> which allows the proper casting of the items from a List to ints. 2. text-matrix.xsl missing {} in attribute value template for $featureURI <a> 3. test-to-java.xsl add subtype processing to <var> 4. test-to-jsunit.xsl fix leading comma problem in version lists
Created attachment 101 [details] patch v1
in dom-to-dtd.xsl, I also added double to the list of types. Left that out of the original comment. Sorry for the bug spam.
Created attachment 104 [details] Changed implementation of JUnitTestCaseAdapter.assertEquals(double
Comment on attachment 104 [details] Changed implementation of JUnitTestCaseAdapter.assertEquals(double Attached to wrong bug, belonged to 428.
The change to the DTD allowing comment elements to appear everywhere violated unambiguous particle attribution constraint. Please use XML comments to comment elements outside the body of the test. I'd like to review the tests that motivated the subtype attribute. I added an optional type attribute to the member element that allows you to specify the type of a member of the element (without that attribute the value is used to determine the type) that may address your requirements. That is, <var name="shortList" type="List"> <member type="short">17</member> </var> If there is a compelling need for type specific lists, I'd prefer the attribute to be named memberType instead of subtype. I also added support for double literals to the schema. I accepted the changes to test-matrix.xsl and test-to-jsunit.xsl.
Created attachment 106 [details] Accepted test-matrix and test-to-jsunit changes, alternative DTD and schema changes
Created attachment 107 [details] Additional patch - cast literals before adding to List I reverted and applied your patch. I still have a couple of issues though. eg: 1) nodeTypeList.add(new Short(7)); 2) inNodeType = (short) nodeTypeList.get(indexd118e113); I can fix 1) by applying the attached patch. I am not sure how to fix 2) though. I would need to look up the member's type attribute and do something like: inNodeType = (short) ((Short)nodeTypeList.get(indexd118e113).shortValue()); I will attach an example test which uses this.
Created attachment 108 [details] Example test XPathResult_resultType.xml using a List of shorts
Created attachment 109 [details] Example test XPathResult_TYPE_ERR.xml using a List of shorts
Created attachment 111 [details] Add support for-each member variables of value types for test-to-java.xsl
These changes work for me. I think you can mark this fixed.