This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 3974 - typos in input-file for trivial-{1,2,3,4} tests
Summary: typos in input-file for trivial-{1,2,3,4} tests
Status: CLOSED FIXED
Alias: None
Product: XML Query Test Suite
Classification: Unclassified
Component: XML Query Test Suite (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal
Target Milestone: ---
Assignee: Andrew Eisenberg
QA Contact: Mailing list for public feedback on specs from XSL and XML Query WGs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-16 22:16 UTC by Per Bothner
Modified: 2007-01-11 19:30 UTC (History)
0 users

See Also:


Attachments

Description Per Bothner 2006-11-16 22:16:15 UTC
The tests trivial-1 and trivial-2 both use the same query
trivial-1.xq, and both declare an input-file binding to
the variable "input-context".  But trivial-1.xq needs an
external variable $input-context1.

Likewise, the tests trivial-3 and trivial-4 both declare
the variable "input-context", and both use trivial-3.xq,
which needs $input-context1.

None of the queries actually *uses* $input-context1, so I'd
just remove the variable declarations.
Comment 1 Carmelo Montanez 2006-12-14 20:34:54 UTC
Per:

Thanks for the comment.  I think you meant "trvial-1" and "trivial-3".  I corrected the typo on the tests.  Rather than removing the declaration alltogether I made it consistent with the catalog file as per out history.
Marking this item as "FIXED".  Please close the bug if in agreement.

Thanks,
Carmelo
Comment 2 Michael Kay 2006-12-14 22:02:14 UTC
Since the "trivial embedding" has been dropped from the spec, these four tests ought to be removed.
Comment 3 Per Bothner 2006-12-18 06:18:59 UTC
(In reply to comment #1)
> Thanks for the comment.  I think you meant "trvial-1" and "trivial-3".  I
> corrected the typo on the tests.  Rather than removing the declaration
> alltogether I made it consistent with the catalog file as per out history.
> Marking this item as "FIXED".  Please close the bug if in agreement.

I did a 'cvs update' and I don't see the fix.

Comment 4 Per Bothner 2006-12-18 06:29:58 UTC
(In reply to comment #2)
> Since the "trivial embedding" has been dropped from the spec, these four tests
> ought to be removed.

Perhaps.  The "trivial embedding" might be a reasonable thing to standardize, but the test-cases are somewhat beside the point.  The trivial embeddeding is not a specification for XQuery per se, but rather a specification for how one might encapsulate XQuery inside an XML file.  As such I don't see that the tests test for anything real - except that there is a way to evaluate a query passed in as a string.
Comment 5 Carmelo Montanez 2006-12-21 16:28:20 UTC
I double check them again and they look fine.  Perhaps Michael is correct,
we should remove these tests.

Carmelo
Comment 6 Per Bothner 2006-12-21 18:16:25 UTC
(In reply to comment #5)
> I double check them again and they look fine.

The trivial-{1,3}.xq files are fixed, but the PublicPagesStagingArea/XQTS_current.zip file isn't updated.  So I manually copied over trivial-{1,3}.xq and now tests trivial-1 and trivial-3 pass.

> Perhaps Michael is correct, we should remove these tests.

If you decide to keep the tests, I'll make a point of getting them working.  As I said, it doesn't make sense to talk about XQuery implementing trivial embedding; just a matter of the *testsuite* implementing the trivial embedding.

Comment 7 Andrew Eisenberg 2007-01-11 19:29:45 UTC
I have removed the test cases for the Trivial XML Embedding Feature.