This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 28040 - Comment about canvas high-res outdated?
Summary: Comment about canvas high-res outdated?
Status: RESOLVED MOVED
Alias: None
Product: WHATWG
Classification: Unclassified
Component: HTML (show other bugs)
Version: unspecified
Hardware: Other other
: P3 normal
Target Milestone: Unsorted
Assignee: Ian 'Hixie' Hickson
QA Contact: contributor
URL: https://html.spec.whatwg.org/#pixel-m...
Whiteboard: [good first bug]
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-17 15:00 UTC by contributor
Modified: 2016-02-10 14:04 UTC (History)
4 users (show)

See Also:


Attachments

Description contributor 2015-02-17 15:00:35 UTC
Specification: https://html.spec.whatwg.org/multipage/scripting.html
Multipage: https://html.spec.whatwg.org/multipage/#pixel-manipulation
Complete: https://html.spec.whatwg.org/#pixel-manipulation
Referrer: https://html.spec.whatwg.org/multipage/

Comment:
Comment about canvas high-res outdated?

     // notice that we are using input.width and input.height here
     // as they might not be the same as canvas.width and canvas.height
     // (in particular, they might be different on high-res displays)

Is this correct given https://html5.org/r/8397 ?

Posted from: 90.230.218.37 by simonp@opera.com
User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.35 Safari/537.36 OPR/28.0.1750.15 (Edition beta)
Comment 1 rits 2016-02-10 12:15:11 UTC
hello, could you give some more details for the issue, thanks!
Comment 2 Anne 2016-02-10 12:45:49 UTC
I guess the comment could be updated to say something like "In this case, input.width and input.height match canvas.width and canvas.height, but we'll use the former to make the code more generic."
Comment 3 rits 2016-02-10 12:59:38 UTC
"In this case we are using, input.width and input.height which match canvas.width and canvas.height, but we'll use the former to make the code more generic."

Is this good?(just gave a try)
Comment 4 Anne 2016-02-10 13:02:04 UTC
Maybe it's better to keep it simpler: "input.width and input.height happen to match canvas.width and canvas.width, but we'll use the former to keep the code generic."
Comment 5 rits 2016-02-10 13:10:50 UTC
okay right, cool.
Comment 6 Simon Pieters 2016-02-10 14:04:16 UTC
https://github.com/whatwg/html/pull/669