This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 1640 - [FS] editorial: 4.7.1.1 Attributes
Summary: [FS] editorial: 4.7.1.1 Attributes
Status: CLOSED FIXED
Alias: None
Product: XPath / XQuery / XSLT
Classification: Unclassified
Component: Formal Semantics 1.0 (show other bugs)
Version: Last Call drafts
Hardware: All All
: P2 minor
Target Milestone: ---
Assignee: Jerome Simeon
QA Contact: Mailing list for public feedback on specs from XSL and XML Query WGs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-15 21:58 UTC by Michael Dyck
Modified: 2007-01-16 17:30 UTC (History)
0 users

See Also:


Attachments

Description Michael Dyck 2005-07-15 21:58:53 UTC
4.7.1.1 Attributes

"Like literal XML element constructors, literal XML attribute constructors
..."
    s/literal XML/direct/g ?

(grammar)
    It would be nice if the relevant productions were moved from 4.7.1 to
    this section.
        DirAttributeList
        DirAttributeValue
        QuotAttrValueContent
        AposAttrValueContent
        QuotAttrContentChar
        AposAttrContentChar
        EscapeQuot
        EscapeApos

Notation
"for the normalization of the content of direct attribute constructors."
    Delete "the content of". Two of them are only concerned with content,
    but []_Attribute is concerned with larger things.

Norm

"The normalization rules for attributes ignore namespace-declaration
attributes"
    Maybe change "for attributes" to "in this section".

"An AttributeList"
    Change to "A DirAttributeList".

Norm / rule 1 / LHS
    Insert an ellipsis.

    'Attributen' is preceded by two double-quotes. Delete one.

Norm / rule (1|2|3)
AttributeValue
    Use of the Formal symbol AttributeValue is completely inappropriate.
    Change
        '"' AttributeValue '"'
    to
        DirAttributeValue
Norm / rule 3 / RHS
    Change 'AttributeValue' to 'DirAttributeValue'.

Norm / rule 3
    Change [[ Prefix:LocalPart ]]_Expr to just Prefix:LocalPart.
    (see 4.7.1 / Norm / rule (3|4) in Bug 1627)

"attribute-content unit"
    There is no definition for this term.

"because the rule ... are applied"
    s/are/is/

Norm / rule (4|5)
"AttributeValueContent"
    The symbol 'AttributeValueContent' is not defined.  At least change
    it to 'AttributeContentUnit' to be consistent with the prose.

Norm / rule (4|5)
[[]]_AttributeContent-unit
    (Similar comments as for _ElementContent-unit in Bug 1627.)

    This construct only appears on the LHS of mapping rules, so there's
    nothing to invoke it.  Probably the RHS of rule 3 is supposed to
    invoke it rather than [[]]_AttributeContent.

    The subscript-names 'AttributeContent' and 'AttributeContent-unit'
    seem to be assigned each other's semantics. That is, the '-unit'
    subscript should be concerned with normalizing a single unit, and the
    other subscript with normalizing the whole content.

    And 'Unit' would match your naming convention better than '-unit'.

Norm / rule 5 / LHS
"AttributeValueContent1 ..., AttributeValueContentn
    Delete comma.

Norm / rule 5 / RHS
"fs:item-sequence-to-untypedAtomic( ... )"
    This function takes a single argument (of type item*), so there should
    be an extra pair of parentheses around what currently appear to be its
    args.

"by normalizing each individual expression in its expression sequence and
then construct a sequence"
    s/construct/constructing/
Comment 1 Michael Dyck 2005-07-15 23:09:54 UTC
(Also...)

Norm / rule 1
"AttributeValue0"
    The subscript should be "1".
Comment 2 Jerome Simeon 2006-04-15 22:51:04 UTC
All comments processed as suggested except for #2 to keep the grammar locations in XQuery 1.0 and FS consistent.

Some of the main changes include:

* Added grammar productions for 'AttributeContentUnit'
* Switched the role of []AttributeContent and []AttributeContentUnit

- Jerome
Comment 3 Michael Dyck 2006-09-29 21:44:04 UTC
I said:
>
> "An AttributeList"
>     Change to "A DirAttributeList".

It's now "An DirAttributeList", so you still need to change "An" to "A".
Comment 4 Jerome Simeon 2006-11-09 22:40:05 UTC
Fixed.
- Jerome