This is an archived snapshot of W3C's public bugzilla bug tracker, decommissioned in April 2019. Please see the home page for more details.

Bug 14067 - Value for createLink and unlink can be null instead of a string
Summary: Value for createLink and unlink can be null instead of a string
Status: RESOLVED FIXED
Alias: None
Product: WebAppsWG
Classification: Unclassified
Component: HISTORICAL - HTML Editing APIs (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: Aryeh Gregor
QA Contact: HTML Editing APIs spec bugbot
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-07 19:36 UTC by Aryeh Gregor
Modified: 2011-09-15 22:28 UTC (History)
2 users (show)

See Also:


Attachments

Description Aryeh Gregor 2011-09-07 19:36:47 UTC
Values should all be strings.  No browser returns values at all for these; I should just remove value/indeterm for now from createLink/unlink.
Comment 1 Aryeh Gregor 2011-09-15 21:10:33 UTC
https://dvcs.w3.org/hg/editing/rev/d0760b6d50a5
Comment 2 Aryeh Gregor 2011-09-15 21:27:48 UTC
The change was broken, reverted:

https://dvcs.w3.org/hg/editing/rev/2d9559086d05

Won't reinstate until I have the tests regenerated.
Comment 3 Aryeh Gregor 2011-09-15 21:50:19 UTC
Turns out there are multiple places where we call queryCommandValue() for createLink, or refer to its value.  As far as I can tell, the only cases right now are in "record current states and values" and "restore states and values".  Working around these is not entirely trivial, since we have to support value overrides in the latter case.  I'll have to add special cases for createLink.  Already done for the former, now need to do it for the latter.  Obnoxiously, it takes ten minutes or so to generate the tests and spot these bugs . . .
Comment 4 Aryeh Gregor 2011-09-15 22:28:02 UTC
Fixed properly this time:

https://dvcs.w3.org/hg/editing/rev/3cc579b879ac

Where "properly" means "with more special cases", naturally.  But it works.