W3C

Disposition of comments for the Device APIs Working Group

Single page view

In the table below, red is in the WG decision column indicates that the Working Group didn't agree with the comment, green indicates that a it agreed with it, and yellow reflects an in-between situation.

In the "Commentor reply" column, red indicates the commenter objected to the WG resolution, green indicates approval, and yellow means the commenter didn't respond to the request for feedback.

CommentorCommentWorking Group decisionCommentor reply
LC-2737 Anne van Kesteren <annevk@annevk.nl> (archived comment)
It seems the feedback I made in
http://lists.w3.org/Archives/Public/public-device-apis/2012Dec/0016.html
applies here too. (Also, IDL has no "string" type, but I agree with
Tab that it should be an enum.)
https://dvcs.w3.org/hg/dap/diff/d3a2ee4266a8/light/Overview.html

reply sent to Anne: http://lists.w3.org/Archives/Public/public-device-apis/2013Jan/0021.html
tocheck
LC-2738 Anne van Kesteren <annevk@annevk.nl> (archived comment)
On Tue, Dec 18, 2012 at 1:27 PM, Anne van Kesteren <annevk@annevk.nl> wrote:
> [...]

I just noticed another thing. The default values for the event members
are not defined. You need to do that, otherwise (new
DeviceLightEvent("trololol").value) is not defined.

See http://dom.spec.whatwg.org/#defining-event-interfaces for advice
on defining new event interfaces.
https://dvcs.w3.org/hg/dap/diff/2f675457d430/light/Overview.html

https://dvcs.w3.org/hg/dap/diff/51296676e203/light/Overview.html

reply sent to Anne: http://lists.w3.org/Archives/Public/public-device-apis/2013Jan/0021.html
tocheck
LC-2736 Tab Atkins Jr. <jackalmage@gmail.com> (archived comment)
Heya! I saw the LC announcement in public-webapps, and have some feedback.

* The introduction isn't very well written - it jumps straight into
technical details (and too much of them), without adequate explanation
of the purpose of the spec and the defined interfaces. I suggest
replacing it with something like:

This specification defines events that provide information about the
ambient light level, as measured by a device's light sensor. A
LightLevelEvent describes the light level as one of three simple
categories - "dim", "normal", and "bright" - while a DeviceLightEvent
provides a more granular answer by describing the light level in terms
of lux units.

* Chapter 5 should start with an intro that describes the event. It's
fine for this to be somewhat repetitive with the spec's own intro -
the point is to make it sensical for someone to jump straight into
this section. I suggest something like:

The DeviceLightEvent interface provides information about the ambient
light levels, as detected by the device's light detector, in terms of
lux units.

* Chapter 5 should have a note (for authors) that the precise lux
value reported by different devices in the same light may be
different, due to differences in detection method, sensor
construction, etc.

* 5.1 and 5.2.3 seem to be duplicate information. I suspect this is a
result of ReSpec, but this should be avoided if possible. Same for
6.1 and 6.2.3.

* Similar, Chapter 6 should have an intro. I suggest something like:

The LightLevelEvent interface provides information about the ambient
light levels, as detected by the device's light detector, in terms of
three general range: "dim", "normal", or "bright".

* The LightLevelEvent interface should use a WebIDL enum, rather than
describing the values solely in prose. Here's the IDL necessary:

enum LightLevel { "dim", "normal", "bright" };
[Constructor (DOMString type, optional LightLevelEventInit eventInitDict)]
interface LightLevelEvent : Event {
readonly attribute LightLevel? value;
};
dictionary LightLevelEventInit : EventInit {
LightLevel? value;
};


* In 6.2.1 (the description of the allowed values for the
LightLevelEvent.value attribute), "may" is used. Either "must" should
be used, or it should be made non-normative and switched to "can" or
something. I think the latter is appropriate, once the enum (above)
is adopted, as the WebIDL constitutes sufficient normative
requirements already.

* In 6.2.2 (the definition of how to fire the event), if the light
level can't be determined, the .value attribute of the event should be
null, not the empty string. I've already handled the nullability in
the WebIDL above.

* In 6.2.2, the prose is a little unclear about when to fire
lightlevel events. I recommend replacing the sentence starting with
"When the current light changes..." and the following note with
something like:

This specification does not define the exact lux ranges that the
LightLevel values map to, as devices with different sensitivities may
want to map them slightly differently. However, it recommends that
"dim" correspond to ambient light below 50lux, "normal" correspond to
light between 50lux and 10000lux, and "bright" correspond to light
above 10000lux. User agents must fire a light level event when the
current light level changes. User agents may fire a light level event
at any other time, for example if they have reason to believe that the
page does not have sufficiently fresh data.

~TJ
The WebIDL was changed to use enum as you suggested, thank you.

Changes were also made to address editorial comments, see the diff https://dvcs.w3.org/hg/dap/rev/1c5fc74bd529
yes
LC-2739 Anne van Kesteren <annevk@annevk.nl> (archived comment)
... from a reviewer's perspective, I would greatly prefer it if we
just put all sensor APIs in a single document. These are quite trivial
APIs and with the current organization most of the content is
boilerplate.)
The WG also has decided to progress the Ambient Light Events and Proximity Events specifications separately to Recommendation to allow independent conformance and testing.

Given that the specifications share commonality the group will also consider a means to produce a combined document for convenience.

Resolution recorded in public minutes:

http://lists.w3.org/Archives/Public/public-device-apis/2013Aug/att-0048/minutes-2013-08-21.html#item04
tocheck

Developed and maintained by Dominique Hazaël-Massieux (dom@w3.org).
$Id: doc.php,v 1.36 2014-02-19 08:10:56 dom Exp $
Please send bug reports and request for enhancements to w3t-sys.org