Talk:SC1-4-1-a

Open issues

Ready for review

• font family, font size (how much difference) font weight (how much difference)

Wilco Fiers (talk) 16:03, 11 February 2016 (UTC)

• Step 1: Typo: "great(er) than"
• Step 1b, 3b, 4b: If the style-properties of the link and its surrounding text are the same, it should not pass.

Frank Berker (talk) 11:58, 11 February 2016 (UTC)

Closed issues

• The text under Introduction is rather long and complicated: "before they receive focus or are activated or the mouse is hovered over the link, or that the link has sufficient color contrast and becomes visually evident when it receives focus or is hovered over with the pointer". Suggestion is to use an unordered list to improve readability.

Raph de Rooij 13:34, 17 June 2015 (UTC)

• In step 1, we are asked to compare a number of properties, including the "border" property. But "border" is a CSS shorthand which includes "border-color". "border-color", when not set, defaults to the value of the "color" property. It seems unintended that the text color is included in this test in this way. It will cause this test to mistakenly return Pass when
  • the "color" properties of the link text and the surrounding text have different values,
  • the border is invisible, and
  • "border-color" is unset,

because the "border-color" properties will default to the value of the "color" properties, making the "border" property appear non-equal in this step while they are equal in a browser where the borders are not shown. Bjørnar Hansen (talk) 12:09, 22 June 2015 (UTC)

• Add assumption: Explain how differences in CSS properties are checked. For color properties the contrast is checked. For other properties it is sufficient that the values are different, there are no thresholds.
• Step 1: Need to check that the color contrast is sufficient if border is used to identify the link.

--Annika Nietzio (talk) 12:05, 16 June 2015 (UTC)

• Step 1 mentions that "The background must be determined…", but the `background` CSS shorthand is not used in the instructions for this step.

Bjørnar Hansen (talk) 14:32, 22 June 2015 (UTC)

• Selector: Merge last two list items "containing text before or after the selected link".
• Step 1+3+4: Typo: "it's" should be "its".

--Annika Nietzio (talk) 13:21, 17 June 2015 (UTC)

• Assumptions: please explain the first assumption
• Selector: link 'non-empty' to its definition
• Step 3: If one or more of these properties [are]

Frank Berker (talk) 13:23, 17 June 2015 (UTC)

• Step 3: "background" should be "background-image".

--Annika Nietzio (talk) 12:05, 16 June 2015 (UTC)

• Shall we consider that links are identifiable by any other means like underlined, bolded, etc in another step?

--Kamyar Rasta (talk) 14:01, 11 June 2015 (UTC)

• make the selector more exact, maybe use javascript properties and be specific about display:block

Feedback from call 2015-06-04

• Step 2: typo: "If C1 or C2 is more then 3:1"
• Add a test name to test properties

--Kamyar Rasta (talk) 14:01, 11 June 2015 (UTC)

• Add a link to C15
• Rework "This test assumes that the checked page has to meet the contrast requirements from WCAG and that there is no conforming alternative version."

Feedback from call 2015-06-04

• General: Unify if... else structure

Frank Berker (talk) 14:01, 7 May 2015 (UTC)

• Step 1: If the only difference is the background-color, we need to continue with step 2 (instead of returning passed). Suggestion: use the same logic as in Step 3.

Annika Nietzio (talk) 13:52, 7 May 2015 (UTC)

• Step 4: 'Move the mouse pointer to the center of the link.' Can this be done automatically?

Twan van Houtum (talk) 9:34, 7 May 2015 (UTC)

• Selector: The selector contains checks for conditions, which could be test steps.

Frank Berker (talk) 14:01, 7 May 2015 (UTC)

• Selector: Simplify to "The link contains text." It is not relevant how many characters there are.
• Assumption: Remove 3rd assumption "This test does not check the dynamic pseudo classes (:hover, :focus, :active)". Focus is checked in step 3. Hover is checked in step 4.
• Step 2 should be "If C1 and C2 is less then 3:1 return failed."

Annika Nietzio (talk) 13:52, 7 May 2015 (UTC)

• Missing Test mode for step 4.

Twan van Houtum (talk) 9:34, 7 May 2015 (UTC)

• Step 1: "The background must be determined by finding the closest ancestor element with it's background set." Do we need this instruction? Isn't this determined by the computed style already?
  • No, because background is not inherited. The background of the link could be transparent and of the paragraph a color. Wilco Fiers (talk) 08:44, 4 May 2015 (UTC)
• Step 1: Unclear instruction "If in either style there is a difference ...". It is not clear whether the difference is within one style or among the two styles. Suggest to move instruction how to extract styles from step 2 to step 1.
• Step 1: Wrong logic. This step must read "If there is no difference, return passed."
• Step 3: The description of this test says "visually evident before they receive focus". However, focus is checked in step 3 ("Give focus to the link.").

--Annika Nietzio (talk) 14:34, 20 November 2014 (UTC)