<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>9955</bug_id>
          
          <creation_ts>2010-06-19 16:14:45 +0000</creation_ts>
          <short_desc>XQuery/Modules/ModuleImportModules/ModuleImport/modules-19.xq through modules-28.xq</short_desc>
          <delta_ts>2010-06-22 15:26:55 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>XML Query Test Suite</product>
          <component>XML Query Test Suite</component>
          <version>unspecified</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sorin Nasoi">spungi</reporter>
          <assigned_to name="Sorin Nasoi">spungi</assigned_to>
          <cc>oliver</cc>
          
          <qa_contact name="Mailing list for public feedback on specs from XSL and XML Query WGs">public-qt-comments</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>36272</commentid>
    <comment_count>0</comment_count>
    <who name="Sorin Nasoi">spungi</who>
    <bug_when>2010-06-19 16:14:45 +0000</bug_when>
    <thetext>There is an error in the cat/ModuleImport.xml for tests modules-19.xq through modules-28.xq:

instead of 
&lt;module namespace=&quot;http://www.w3.org/TestModules/defs&quot;&gt;module3-lib&lt;/module&gt;
it should be
&lt;module namespace=&quot;http://www.w3.org/TestModules/defs&quot;&gt;module-defs&lt;/module&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36273</commentid>
    <comment_count>1</comment_count>
    <who name="Sorin Nasoi">spungi</who>
    <bug_when>2010-06-19 16:33:27 +0000</bug_when>
    <thetext>I have committed a fix today for tests modules-19.xq through modules-27.xq
modules-28.xq seems to be correct.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36301</commentid>
    <comment_count>2</comment_count>
    <who name="Oliver Hallam">oliver</who>
    <bug_when>2010-06-21 10:46:20 +0000</bug_when>
    <thetext>Your fix seems to have broken all these tests.

The tests all import a module with namespace &apos;http://www.w3.org/TestModules/test1&apos;

Firstly, the purpose of these tests was to test the errors that occur when importing modules with schema types, yet module-defs does not have any schema types, so module3-lib was definitely the correct module to import.

Secondly, module-defs imports a module with namespace &quot;http://www.w3.org/TestModules/test1&quot;, yet no &lt;module&gt; declaration exists for this module.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36319</commentid>
    <comment_count>3</comment_count>
    <who name="Sorin Nasoi">spungi</who>
    <bug_when>2010-06-22 06:55:04 +0000</bug_when>
    <thetext>Hi,
all the tests I mentioned (modules-19.xq through modules-27.xq) import module defs with namespace &quot;http://www.w3.org/TestModules/defs.

If you check out the module moduleDefs-lib written by Carmelo Montanez you will see that it import a library module test1 with namespace &quot;http://www.w3.org/TestModules/test1&quot;.

I agree that the fix is wrong, I will fix them today, but initially the tests were wrong: the main module module-3.lib defines the namespace &quot;http://www.w3.org/TestModules/defs&quot; which is the same as the namespace for module moduleDefs-lib. This creates a break when you try to process XQTS, the namespaces of the modules should be unique.

The correct fix would be to:
- change the namespace of module3-lib to something like &quot;http://www.w3.org/TestModules/module3&quot; and then in the tests import module3-lib with this namespace.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36321</commentid>
    <comment_count>4</comment_count>
    <who name="Sorin Nasoi">spungi</who>
    <bug_when>2010-06-22 07:09:48 +0000</bug_when>
    <thetext>I have just committed a new fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36335</commentid>
    <comment_count>5</comment_count>
    <who name="Oliver Hallam">oliver</who>
    <bug_when>2010-06-22 15:26:55 +0000</bug_when>
    <thetext>I don&apos;t think it is a requirement for modules in the catalog to all have distinct URIs, but keeping them distinct can only be a good thing.  

I agree with your fix so I will mark the bug CLOSED (since you have already indicated that this resolves your problem).</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>