978 2004-12-30 11:30:27 +0000 systematic xml preparse mode triggers wrong parse mode for xml documents with broken xml declaration 2007-03-28 01:48:09 +0000 1 1 1 Unclassified Validator check 0.6.7 PC Windows XP RESOLVED FIXED http://qa-dev.w3.org/wmvs/HEAD/dev/tests/bogus-xmlpi.html P3 blocker 0.8.0 1 phlucas ot www-validator-cvs oldest_to_newest 2767 0 phlucas 2004-12-30 11:30:27 +0000 I am trying to convert a HTML 4.01 strict web page to XHTML. My first attempt apparently failed, but the validator does not tell me why. I stripped most content of the page, so that it consists now only of an XHTML skeleton. "This page is not Valid ! Below are the results of attempting to parse this document with an SGML parser." ... and that's it. Surely the validator should tell me the problem. The page in question is http://rw4.cs.uni-sb.de/~phlucas/Lehre/semss05.xhtml. 2768 1 bjoern 2004-12-30 15:27:10 +0000 <?xml version="1.0" encoding="UTF-8"> must be <?xml version="1.0" encoding="UTF-8"?> 4209 2 link 2005-02-04 13:39:22 +0000 While we don't catch this error specifically, the current development code will, due to other code changes, no longer produce empty results. 6804 3 ot 2005-10-20 06:16:41 +0000 Update: latest release (0.7.1) still sends empty result, while current development code (HEAD, 0.8-dev) reports error beyond the boundaries of the document validated. 14052 4 ot 2007-02-22 05:56:17 +0000 renaming, raising priority. 14527 5 ot 2007-03-22 09:12:10 +0000 http://qa-dev.w3.org/wmvs/HEAD/check?uri=http%3A%2F%2Fqa-dev.w3.org%2Fwmvs%2FHEAD%2Fdev%2Ftests%2Fbogus-xmlpi.html;debug is useful in understanding what's happening. * an XHTML document is sent as text/html (curse the day text/html was said to be OK for XHTML...) * the parse mode is set to TBD * preparse looks at document - by default HTML::Parser was set to XML mode - pre-parsing cannot find end of XML declaration, and thus parses the whole doc as if... - the doctype cannot be found * as a result, XML mode is NOT triggered * openSP is launched in SGML mode * openSP parses the XML DTD as an SGML DTD, whines * errors are reported in the DTD (which is why it looks as though it reports errors in the document, but at odd lines). FIX: use pre-parser as XML mode only if the content-type has unambiguously shown that we should do so. In the case of text/html, cautiously use SGML pre-parsing. Finding an XHTML document type will later trigger xml mode in the actual parser and validator. [[ my $p = HTML::Parser->new(api_version => 3); - $p->xml_mode(TRUE); + # if content-type has shown we should pre-parse with XML mode, use that + # otherwise (mostly text/html cases) use default mode + $p->xml_mode(TRUE) if ($File->{Mode} eq 'XML'); ]] I have to test this patch against a number of other test cases, but I'm hopeful it should be the solution to this problem, as well as Bug #14. 14528 6 ot 2007-03-22 09:12:58 +0000 Assigning to me. 14558 7 ot 2007-03-28 01:48:09 +0000 Patch mentioned in Comment #5 has been applied, and it works, as far as I (and my tests) can tell. closing.