717 2004-05-15 05:46:48 +0000 Shown source loses indentation 2004-05-17 22:04:21 +0000 1 1 1 Unclassified Validator check 0.6.5 Other other VERIFIED FIXED P2 normal 0.6.6 1 ville.skytta ville.skytta link oldest_to_newest 1820 0 ville.skytta 2004-05-15 05:46:48 +0000 There are many reports on www-validator@ about this. Will attach a patch which works4me, tested with Firefox, Konqueror, and Opera on Linux. 1821 1 365 ville.skytta 2004-05-15 05:47:50 +0000 Created attachment 365 Candidate fix for preserving source indentation 1833 2 link 2004-05-16 03:19:19 +0000 Applied a modified version of that patch. Take look and see that I didn't goof up anywhere Ville? I note that the line numbers aren't lining up for some reason. Since it's annoying but not critical I didn't bother spending more time on it right now. 1844 3 366 ville.skytta 2004-05-16 06:20:56 +0000 Created attachment 366 More small show source tweaks Still works for me mostly. Attached is a few more tweaks: - Remove line break after <pre> and whitespace before </pre> to avoid unwanted "padding" inside the source code box. - Use <a id="..." name="..."> compatibility bloat since we're using it elsewhere as well. 1864 4 ville.skytta 2004-05-17 17:41:14 +0000 Nitpickery and micro tuning: the "no newline after <pre>" and "no whitespace before </pre>" changes from attachment 366 were lost when applying this, it seems. Just confirming if that was intentional or not... some browsers tend to add unwanted blank lines in these cases as was mentioned in comment 3. 1867 5 link 2004-05-17 17:59:58 +0000 Ah, sorry, I'd meant to remark on that. I deliberately dropped that bit of the patch. It made the code slightly uglier and I really don't see any problem with the whitespace at the beginning/end of the <pre/ > section. If browsers decide to show an extra blank line then that's just a little extra "air" in addition to the padding we set explicitly. If you feel strongly about it then just change it in CVS. 1868 6 ville.skytta 2004-05-17 18:04:21 +0000 Definitely not a big issue, thanks for the explanation. 365 2004-05-15 05:47:50 +0000 2004-05-16 06:20:56 +0000 Candidate fix for preserving source indentation srcindent.patch text/plain 1549 ville.skytta PyBodHRwZC9jZ2ktYmluL2MuZGlmZgpJbmRleDogaHRkb2NzL3Jlc3VsdHMuY3NzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3B1YmxpYy92YWxpZGF0b3IvaHRkb2NzL3Jlc3VsdHMuY3Nz LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzLjIuMjgKZGlmZiAtYSAtdSAtcjEuMTMuMi4yOCBy ZXN1bHRzLmNzcwotLS0gaHRkb2NzL3Jlc3VsdHMuY3NzCTMwIEFwciAyMDA0IDA0OjA1OjQwIC0w MDAwCTEuMTMuMi4yOAorKysgaHRkb2NzL3Jlc3VsdHMuY3NzCTE1IE1heSAyMDA0IDA5OjQ0OjE5 IC0wMDAwCkBAIC0xMDIsMTIgKzEwMiwxNiBAQAogICBwYWRkaW5nLXJpZ2h0OiAxZW07CiB9CiAK LSNzb3VyY2UgY29kZSB7Ci0gIHdoaXRlLXNwYWNlOiBub3JtYWw7Ci0gIGZvbnQtZmFtaWx5OiAi Qml0c3RyZWFtIFZlcmEgTW9ubyIsIG1vbm9zcGFjZTsKKyNzb3VyY2UgcHJlIHsKICAgZm9udC1z aXplOiBzbWFsbGVyOwogfQogCisjc291cmNlIHByZSBhIHsKKyAgY29sb3I6IGluaGVyaXQ7Cisg IGJhY2tncm91bmQtY29sb3I6IGluaGVyaXQ7CisgIHRleHQtZGVjb3JhdGlvbjogbm9uZTsKK30K KwogCiBmaWVsZHNldCB7CiAgIGNvbG9yOiBibGFjazsKSW5kZXg6IGh0dHBkL2NnaS1iaW4vY2hl Y2sKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3NvdXJjZXMvcHVibGljL3ZhbGlkYXRvci9odHRwZC9j Z2ktYmluL2NoZWNrLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjMwNS4yLjExNQpkaWZmIC1hIC11 IC1yMS4zMDUuMi4xMTUgY2hlY2sKLS0tIGh0dHBkL2NnaS1iaW4vY2hlY2sJMTUgTWF5IDIwMDQg MDc6MjE6MzQgLTAwMDAJMS4zMDUuMi4xMTUKKysrIGh0dHBkL2NnaS1iaW4vY2hlY2sJMTUgTWF5 IDIwMDQgMDk6NDQ6MzQgLTAwMDAKQEAgLTIyMTgsMTQgKzIyMTgsMTYgQEAKICAgICA8cD5CZWxv dyBpcyB0aGUgc291cmNlIGlucHV0IEkgdXNlZCBmb3IgdGhpcyB2YWxpZGF0aW9uOjwvcD4KICAg ICAkY29tbWVudAogICAgIDxkaXY+CisgICAgICA8cHJlPgogRU9GCiAKICAgZm9yIChAeyRGaWxl LT57Q29udGVudH19KSB7Ci0gICAgbXkgJGhsaW5lID0gKCcmbmJzcDsnIHggKDQgLSBsZW5ndGgg IiRsaW5lIikpIC4gJGxpbmU7Ci0gICAgcHJpbnRmIHFxKDxjb2RlIGlkPSJsaW5lLSVzIj4lczog JXM8L2NvZGU+PGJyLz5cbiksICRsaW5lLCAkaGxpbmUsIGVudCAkXzsKKyAgICBteSAkaGxpbmUg PSAoJyAnIHggKDQgLSBsZW5ndGggIiRsaW5lIikpIC4gJGxpbmU7CisgICAgcHJpbnRmIHFxKDxh IGlkPSJsaW5lLSVzIiBuYW1lPSJsaW5lLSVzIj4lczogJXM8L2E+XG4pLAorICAgICAgJGxpbmUs ICRsaW5lLCAkaGxpbmUsIGVudCAkXzsKICAgICAkbGluZSsrOwogICB9Ci0gIHByaW50ICIgICAg PC9kaXY+XG4gIDwvZGl2PiI7CisgIHByaW50ICI8L3ByZT5cbiAgICA8L2Rpdj5cbiAgPC9kaXY+ IjsKIH0KIAogCg== 366 2004-05-16 06:20:56 +0000 2004-05-16 06:20:56 +0000 More small show source tweaks sourcetweak.patch text/plain 1026 ville.skytta SW5kZXg6IGNoZWNrCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3B1YmxpYy92YWxpZGF0 b3IvaHR0cGQvY2dpLWJpbi9jaGVjayx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMDUuMi4xMjQK ZGlmZiAtYSAtdSAtcjEuMzA1LjIuMTI0IGNoZWNrCi0tLSBjaGVjawkxNiBNYXkgMjAwNCAwOTow MToyNyAtMDAwMAkxLjMwNS4yLjEyNAorKysgY2hlY2sJMTYgTWF5IDIwMDQgMTA6MTM6NTEgLTAw MDAKQEAgLTIyMjYsMTYgKzIyMjYsMTcgQEAKICAgICA8cD5CZWxvdyBpcyB0aGUgc291cmNlIGlu cHV0IEkgdXNlZCBmb3IgdGhpcyB2YWxpZGF0aW9uOjwvcD4KICAgICAkY29tbWVudAogICAgIDxk aXY+Ci0gICAgICA8cHJlPgogRU9GCisgIHByaW50ICcgICAgICA8cHJlPic7ICMgbm8gbmV3bGlu ZSBhZnRlciAuLi4KIAorICBteSAkbWF4aGxlbiA9IGxlbmd0aCgiJGxpbmVzIik7CiAgIGZvciAo QHskRmlsZS0+e0NvbnRlbnR9fSkgewotICAgIG15ICRobGluZSA9ICgnICcgeCAobGVuZ3RoKCIk bGluZXMiKSAtIGxlbmd0aCgiJGxpbmUiKSkpIC4gJGxpbmU7Ci0gICAgcHJpbnRmIHFxKDxhIGlk PSJsaW5lLSVzIj48c3Ryb25nPiVzPC9zdHJvbmc+OiAlczwvYT5cbiksCi0gICAgICAkbGluZSwg JGhsaW5lLCBlbnQgJF87CisgICAgbXkgJGhsaW5lID0gKCcgJyB4ICgkbWF4aGxlbiAtIGxlbmd0 aCgiJGxpbmUiKSkpIC4gJGxpbmU7CisgICAgcHJpbnRmIHFxKDxhIGlkPSJsaW5lLSVzIiBuYW1l PSJsaW5lLSVzIj48c3Ryb25nPiVzPC9zdHJvbmc+OiAlczwvYT5cbiksCisgICAgICAkbGluZSwg JGxpbmUsICRobGluZSwgZW50ICRfOwogICAgICRsaW5lKys7CiAgIH0KLSAgcHJpbnQgIiAgICAg IDwvcHJlPlxuICAgIDwvZGl2PlxuICA8L2Rpdj4iOworICBwcmludCAiPC9wcmU+XG4gICAgPC9k aXY+XG4gIDwvZGl2PiI7ICMgbm8gd2hpdGVzcGFjZSBiZWZvcmUgPC9wcmU+IC4uLgogfQogCiAK