6934 2009-05-20 16:39:12 +0000 Comments occur before the version declaration in test cases 2009-10-14 16:09:13 +0000 1 1 1 Unclassified XML Query Test Suite XML Query Test Suite 1.0.2 All All CLOSED FIXED P2 normal --- 1 josh.spiegel frans.englich josh.spiegel mike public-qt-comments oldest_to_newest 25229 0 josh.spiegel 2009-05-20 16:39:12 +0000 In many test cases (e.g. K-VersionProlog-1) comments occur before the version declaration. This seems to be contrary to the XQuery specification: "If a version declaration is present, no Comment may occur before the end of the version declaration. If such a Comment is present, the result is implementation-dependent." see http://www.w3.org/TR/xquery/#id-version-declaration, section 4.1, 4th paragraph. In our implementation, we will raise an error in such cases. 25247 1 mike 2009-05-21 06:54:57 +0000 Any chance you could enumerate the test cases concerned? 25252 2 josh.spiegel 2009-05-21 17:11:05 +0000 Here are tests I found in ./XQTS/Queries/XQuery/ which have comments before a version declaration: Expressions/PrologExpr/VersionProlog/K-VersionProlog-1.xq Expressions/PrologExpr/VersionProlog/K-VersionProlog-2.xq Expressions/PrologExpr/VersionProlog/K-VersionProlog-3.xq Expressions/PrologExpr/VersionProlog/K-VersionProlog-4.xq Expressions/PrologExpr/VersionProlog/K-VersionProlog-5.xq Expressions/PrologExpr/VersionProlog/version_declaration-001.xq Expressions/PrologExpr/VersionProlog/version_declaration-002.xq Expressions/PrologExpr/VersionProlog/version_declaration-003.xq Expressions/PrologExpr/VersionProlog/version_declaration-004.xq Expressions/PrologExpr/VersionProlog/version_declaration-006.xq Expressions/PrologExpr/VersionProlog/version_declaration-007.xq Expressions/PrologExpr/VersionProlog/version_declaration-008.xq Expressions/PrologExpr/VersionProlog/version_declaration-009.xq Expressions/PrologExpr/VersionProlog/version_declaration-010.xq SchemaImport/versionPrologSI/version_declaration-005.xq Here are tests I found in ./XQTS/Queries/XQuery/ which have a version declaration without preceding comments: Expressions/PrologExpr/VersionProlog/prolog-version-1.xq Expressions/PrologExpr/VersionProlog/prolog-version-10.xq Expressions/PrologExpr/VersionProlog/prolog-version-11.xq Expressions/PrologExpr/VersionProlog/prolog-version-12.xq Expressions/PrologExpr/VersionProlog/prolog-version-3.xq Expressions/PrologExpr/VersionProlog/prolog-version-4.xq Expressions/PrologExpr/VersionProlog/prolog-version-5.xq Expressions/PrologExpr/VersionProlog/prolog-version-6.xq Expressions/PrologExpr/VersionProlog/prolog-version-7.xq Expressions/PrologExpr/VersionProlog/prolog-version-9.xq SchemaImport/versionPrologSI/prolog-version-8.xq 25254 3 mike 2009-05-21 17:36:29 +0000 I think the author of the test in many/most of these cases probably didn't intend the comment to appear before the version declaration. However, the expected test results in most cases do seem to allow an error to be reported, so it's not clear to me that the expected results are incorrect for these tests. 25257 4 josh.spiegel 2009-05-21 18:58:34 +0000 First of all, thank you Dr. Kay for your quick attention to this issue. It is my understanding that of the 15 tests I listed, only version_declaration-001,002,003,004 will pass with any error. The remaining 11 tests either expect a specific error or no error at all. In other words, our implementation that throws an error when comments occur before the declaration will fail the 11 tests when it should not. Forgive me if this is incorrect. 28343 5 frans.englich 2009-10-14 14:17:42 +0000 Those 15 tests should now be fixed to have the version declaration in the beginning. Might be I missed something. 28351 6 josh.spiegel 2009-10-14 16:09:13 +0000 Verified. Thanks!