6286 2008-12-06 22:32:08 +0000 XML comments are incorrectly counted in HTTPXHTMLResource.java 2008-12-06 22:34:13 +0000 1 1 1 Unclassified mobileOK Basic checker Java Library unspecified PC Linux RESOLVED FIXED P2 normal --- 1 fd abel.rionda oldest_to_newest 22701 0 fd 2008-12-06 22:32:08 +0000 The regular expression used to match comments in HTTPXHTMLResource.java is defined as: Pattern.compile("(<!-- .* -->)", Pattern.MULTILINE); This is incorrect because: 1. "." does not match new lines unless the Pattern.DOTALL is also set 2. regular expression are greedy in Java, meaning that if there is one comment at the beginning of the document and one comment at the end, the regular expression will just match the entire document between the beginning of the first comment and the end of the second one 3. There may be no space between the beginning and the end of the comment, i.e. "<!--comment-->" is a valid comment. The correct regular expression should rather be: Pattern.compile("(<!--.*?-->)", Pattern.MULTILINE | Pattern.DOTALL); 22702 1 fd 2008-12-06 22:34:13 +0000 Fixed regular expression in HTTPXHTMLResource.java