<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>5686</bug_id>
          
          <creation_ts>2008-05-14 08:57:30 +0000</creation_ts>
          <short_desc>K2-Literals-28, K2-Literals-39</short_desc>
          <delta_ts>2008-06-24 12:44:23 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>XML Query Test Suite</product>
          <component>XML Query Test Suite</component>
          <version>unspecified</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows NT</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Kay">mike</reporter>
          <assigned_to name="Frans Englich">frans.englich</assigned_to>
          
          
          <qa_contact name="Mailing list for public feedback on specs from XSL and XML Query WGs">public-qt-comments</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>20088</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Kay">mike</who>
    <bug_when>2008-05-14 08:57:30 +0000</bug_when>
    <thetext>In test K2-Literals-28, the literal as written in the source contains the whitespace sequence

20 0D 0D 0D 20 0D 0D 0A

The published results appear to expect this to be normalized to

20 0A 0A 0A 20 0A

I believe the correct normalization is to

20 0A 0A 0A 20 0A 0A

The same problem affects K2-Literals-39

Michael Kay</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20089</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Kay">mike</who>
    <bug_when>2008-05-14 10:12:44 +0000</bug_when>
    <thetext>The same problem affects tests 

K2-DirectConOther-50
K2-DirectConOther-52
K2-DirectConOther-54
K2-DirectConOther-66
K2-DirectConOther-68
K2-DirectConOther-69
K2-DirectConOther-70

The tests appear to be written in the belief that a sequence of 0D characters followed by a 0A should be normalized to a single 0A. I think this is incorrect. The XQuery rules are in A2.3 (they both reference the XML 1.0 rules, and paraphrase them, which is unwise, but I think the paraphrase is correct). The XML 1.0 rules are in 2.11.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20097</commentid>
    <comment_count>2</comment_count>
    <who name="Nick Jones">nick</who>
    <bug_when>2008-05-15 10:19:51 +0000</bug_when>
    <thetext>I&apos;ve just looked at the files you mention and the source files I&apos;m getting do not match what you are describing, so for the sources I get:

$ od -c -t x1 K2-Literals-28.xq

0000560   a     \r \r \r    \r \n s  t  r  i  n  g     l
          61 20 0d 0d 0d 20 0d 0a 73 74 72 69 6e 67 20 6c


$ od -c -t x1 K2-Literals-39.xq

0000600   *  :  )  \n &apos;  a     \r \r \r    \r \n s  t  r
          2a 3a 29 0a 27 61 20 0d 0d 0d 20 0d 0a 73 74 72

For those sources I think the current results are correct.

What are your file details? I&apos;ve got:

-rw-r--r-- 1 nick mkgroup-l-d 393 Dec 20 17:05 K2-Literals-28.xq
-rw-r--r-- 1 nick mkgroup-l-d 414 Jan 24 11:02 K2-Literals-39.xq</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20098</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Kay">mike</who>
    <bug_when>2008-05-15 10:46:25 +0000</bug_when>
    <thetext>Thanks for the info. The timestamps on my files match (modulo timezone), but the contents don&apos;t. I&apos;m seeing in K2-Literals-28

61 20 0d 0d 0d 20 0d 0d 0a 73 74 72

where you have 

61 20 0d 0d 0d 20 0d 0a 73 74 72

I guess something (CVS?) has tried to be clever and added a 0d before every 0a. I&apos;ve just deleted the file and done a CVS update: no change.

I notice TortoiseCVS has an option &quot;Sandbox DOS/UNIX&quot; which despite the name apparently controls LF/CRLF endings in text files. It is currently set to &quot;Autodetect (default to DOS)&quot;. It&apos;s not clear that any of the other options (DOS|UNIX|Autodetect (default to UNIX)) would be any better overall, though they might fix the problems for these files. I don&apos;t see an option to treat all files as binary.

Perhaps I&apos;ll just have to wait until someone builds a new ZIP file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20099</commentid>
    <comment_count>4</comment_count>
    <who name="David Carlisle">davidc</who>
    <bug_when>2008-05-15 11:08:48 +0000</bug_when>
    <thetext>I tried to update my cvs to check but the server is not letting me in any more has the psererver account for anonymous access chaged in recent months?

It would probably be best if all the white space sennsitive files (input and results) were checked in as binary

cvs admin -kb *

from a machine where they are currently right, then CVS won&apos;t mangle them on checkout.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20100</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Mills">tim</who>
    <bug_when>2008-05-15 12:15:06 +0000</bug_when>
    <thetext>I use TortoiseCVS and have Sandbox set to UNIX.  

A message pops up saying

&quot;cvs: Obsolete --lf option used.  Please update your client.&quot;

but it does actually seem to fix the problem!

You may have to delete the offending files to force an update.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20123</commentid>
    <comment_count>6</comment_count>
    <who name="Andrew Eisenberg">andrew.eisenberg</who>
    <bug_when>2008-05-15 20:29:33 +0000</bug_when>
    <thetext>Mike, you can also get the file you want from the web interface to our CVS repository, http://dev.w3.org/cvsweb/2006/xquery-test-suite/. The specific file you want is http://dev.w3.org/2006/xquery-test-suite/TestSuiteStagingArea/Queries/XQuery/Express
ions/PrimaryExpr/Literals/K2-Literals-28.xq.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20134</commentid>
    <comment_count>7</comment_count>
    <who name="Frans Englich">frans.englich</who>
    <bug_when>2008-05-16 08:55:21 +0000</bug_when>
    <thetext>Yeah, don&apos;t we all just love CVS. The conversion of line endings have been a problem for other tests as well.

I marked the baselines for the mentioned tests as binaries, although this is of course a bit of hackish solution. But maybe this fixed at least these tests. Unfortunately CVS has no clean solution for this.

Changing the default EOL behavior of the client may also be a solution, as suggested.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20781</commentid>
    <comment_count>8</comment_count>
    <who name="Frans Englich">frans.englich</who>
    <bug_when>2008-06-24 12:44:23 +0000</bug_when>
    <thetext>I assume the changes described in #7 fixed it, reopen otherwise.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>