5334 2008-01-01 22:15:06 +0000 [UPD] Inserting attributes 2008-01-26 22:59:13 +0000 1 1 1 Unclassified XPath / XQuery / XSLT Update Facility Last Call drafts PC Windows XP CLOSED WONTFIX P2 normal --- 1 mike andrew.eisenberg public-qt-comments oldest_to_newest 18173 0 mike 2008-01-01 22:15:06 +0000 The rules on insertion of attributes seem highly arbitrary. You are allowed to say insert node @a after $x/*[12] and it happily adds a copy of @a to $x, ignoring the requested position. You can also say insert nodes (@a, <e/>) after $x/*[12] and it happily inserts @a as an attribute of $x, and adds <e/> as its 13th child element. But you can't say insert nodes (<e/>, @a) after $x/*[12] because the source expression isn't allowed to have an attribute appearing after a non-attribute. This seems very inconsistent. I would suggest either relaxing the rules by eliminating error XUTY0004, or making the rules stricter by disallowing all use of positional qualifiers (after, before, as first, as last) when the source expression contains an attribute. 18299 1 chamberl 2008-01-15 01:09:54 +0000 Eliminating XUTY0004 seems reasonable. It was defined by analogy with XQTY0024, but it could be argued that the analogy is weak because XQTY0024 applies only to element constructors. 18325 2 zhen.liu 2008-01-15 19:29:32 +0000 I'd like to retain what the current xquery update spec states, that is, XUTY0004 to be raised for the following reasons: (1) It is consistent with the xquery 1.0 for element constructor for raising XQTY0024 error. (2) The original reason, I suspected, that XQTY0024 error is raised for element constructor, is for streaming implementation. I think similar arguments held for insert node. (3) Some implementations may rewrite (transform) some 'insert expression' into element constructor. In such case, it is appreciated they share the same rules. 18462 3 jonathan.robie 2008-01-22 19:56:39 +0000 In XQuery 1.0, this raises an error: let $x := ( attribute a { "a" }, element b { "b" }, attribute c { "c" } ) return <foo> { $x } </foo> That leads me to expect the following to be an error: let $x := ( attribute a { "a" }, element b { "b" }, attribute c { "c" } ) let $f := <foo></foo> return insert nodes $x into $f 18467 4 mike 2008-01-22 20:47:11 +0000 Concerning comment #3: yes, for "insert into" that would be a reasonable expectation. What makes it unreasonable is that we allow "insert after" to insert a new attribute "after" an existing child element. If there's an existing child <c/> and we can insert (@a, <e/>) after <c/>, then clearly this involves some rearrangement of the sequence (@a, <e/>); and if this sequence can be rearranged, then so can (<e/>, @a). 18598 5 chamberl 2008-01-26 22:04:41 +0000 Michael, On 22 Jan 2008, the Query Working Group decided not to make any change to the Update specification based on this bug report. The reason for this decision is to preserve consistency between insert expressions and element constructors in XQuery 1.0. If you are satisfied with this resolution, please change the status of this bug to Closed. --Don Chamberlin (for the Query Working Group)