4342 2007-02-22 04:14:22 +0000 Revalidation form for Upload and Direct Input 2008-12-01 03:03:03 +0000 1 1 1 Unclassified Validator Templates HEAD All All RESOLVED FIXED P3 enhancement 0.8.2 1 ot brett.bieber aaz www-validator-cvs oldest_to_newest 14041 0 ot 2007-02-22 04:14:22 +0000 At the moment only the "By URI" validation method has, in the results page, a form to revalidate the document online. It was suggested that: - for "direct input", the form could be given too, with the textarea pre-filled with the given data (properly escaped) - for "file upload", the form could be given, with an empty file field and a note that it has to be set again. 14662 1 ot 2007-04-04 04:08:07 +0000 Won't make it for 0.8.0. Maybe for a 0.8.x 16358 2 484 brett.bieber 2007-09-05 02:20:00 +0000 Created attachment 484 template patch for bug 4342 A couple changes, always populate the file source, and always show the encoding and doctype dropdowns. One possible problem is the content within the textarea has an added newline character to the last line -- usually not a problem. 16361 3 ot 2007-09-05 08:30:03 +0000 (In reply to comment #2) > Created an attachment (id=484) [edit] > template patch for bug 4342 Excellent! Your patch looks good, I applied it a few minutes ago. (I'm "giving" the bug to you ;) as a result) > A couple changes, always populate the file source I made a little patch to this, to not pass the file source to the template object if not needed (so as to save a bit of proc/memory footprint). One thing that surprised me in your implementation is that you give the source as direct input even in the case of file upload. Was this a deliberate choice? I guess it would make sense from usability perspective, since at least a textarea can be pre-filled with the content while a file upload control could not. It just might be a little surprising, and I can imagine some hairy issues (related to XML detection or charset), but this may be a good compromise nevertheless. Working in this area could also be an opportunity to clean up the usage of $File->{'Is Upload'} and $File->{'Direct Input'}. I can't understand why the former is TRUE when the input mode actually is "Direct input". 16387 4 brett.bieber 2007-09-05 20:00:43 +0000 (In reply to comment #3) > I made a little patch to this, to not pass the file source to the template > object if not needed (so as to save a bit of proc/memory footprint). Ahh yes, very good. > One thing that surprised me in your implementation is that you give the source > as direct input even in the case of file upload. Was this a deliberate choice? Not deliberate... but the 'File Upload' results page suffers from the same problem Alastair McKenzie noted, no easy way to re-validate the file. > I guess it would make sense from usability perspective, since at least a > textarea can be pre-filled with the content while a file upload control could > not. It just might be a little surprising, and I can imagine some hairy issues > (related to XML detection or charset), but this may be a good compromise > nevertheless. This may be the best compromise --- I find copying and pasting the content easier than a file choosing window, but I'm sure some will want the file upload interface again. We could provide a file input to choose the file again...? > Working in this area could also be an opportunity to clean up the usage of > $File->{'Is Upload'} and $File->{'Direct Input'}. I can't understand why the > former is TRUE when the input mode actually is "Direct input". > Right, this is somewhat confusing, and even now on file upload results the <th> left of the textarea states "Direct Input" instead of "File" (regression?). Hard to predict what people will find more useful, a textarea populated with the content or a blank file input. I suspect most users would expect a input for file upload --- and then complain that it wasn't automatically populated with the file they chose in the previous screen. :-) 16450 5 ot 2007-09-11 05:17:05 +0000 (In reply to comment #4) > Not deliberate... but the 'File Upload' results page suffers from the same > problem Alastair McKenzie noted, no easy way to re-validate the file. > > Hard to predict what people will find more useful, a textarea populated with > the content or a blank file input. I suspect most users would expect a input > for file upload --- and then complain that it wasn't automatically populated > with the file they chose in the previous screen. :-) Right. I actually think that most people would be happier with a pre-filled textarea than an empty file input, but I'm always wary of pretending to know what people want. If people are using file upload in the first place, maybe they prefer file upload... For now, I think I want to clean up the $File->{'Is Upload'} and $File->{'Direct Input'} mess, and survey the list for opinions (knowing full well that the list is not entirely representative of all the users, but that's a pool of users nonetheless). Then we can decide which way to go. Delaying the 0.8.2 release a few days for this won't be too much of an issue. 16451 6 ot 2007-09-11 05:19:10 +0000 I also modified the template to use the POST method when revalidating through the textarea. Doing this with GET would be problematic. 16476 7 ot 2007-09-12 06:16:13 +0000 (In reply to comment #5) > For now, I think I want to clean up the $File->{'Is Upload'} and > $File->{'Direct Input'} mess Done in CVS. In Upload mode the form shows a file upload control, in direct input, it shows the source in a textarea. I'll post something to survey for opinions/ideas. 16496 8 brett.bieber 2007-09-12 13:37:04 +0000 Thanks Olivier.. everything looks great. Feel free to close when you're ready, otherwise I'll wait for feedback to your post on the list - then close when a consensus is reached. 17011 9 ot 2007-10-03 08:19:36 +0000 Seeing no objection (no opinion at all actually) for now on the mail thread, I'll close this. Let's revisit when/if the public release provides us with more feedback. 484 2007-09-05 02:20:00 +0000 2007-09-05 02:20:00 +0000 template patch for bug 4342 validator_4342.patch.txt text/plain 3987 brett.bieber IyMjIEVjbGlwc2UgV29ya3NwYWNlIFBhdGNoIDEuMAojUCB2YWxpZGF0b3IKSW5kZXg6IHNoYXJl L3RlbXBsYXRlcy9lbl9VUy90YWJsZS50bXBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2Vz L3B1YmxpYy92YWxpZGF0b3Ivc2hhcmUvdGVtcGxhdGVzL2VuX1VTL3RhYmxlLnRtcGwsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMjgKZGlmZiAtdSAtcjEuMjggdGFibGUudG1wbAotLS0gc2hhcmUv dGVtcGxhdGVzL2VuX1VTL3RhYmxlLnRtcGwJNyBNYXkgMjAwNyAxOToxNzo1OCAtMDAwMAkxLjI4 CisrKyBzaGFyZS90ZW1wbGF0ZXMvZW5fVVMvdGFibGUudG1wbAk1IFNlcCAyMDA3IDAyOjA4OjQ1 IC0wMDAwCkBAIC0zNiw3ICszNiw4IEBACiAgICAgPC90cj4KICAgICA8dHI+CiA8VE1QTF9JRiBO QU1FPSJpc191cGxvYWQiPgotICAgICAgPHRoPkZpbGU6PC90aD48dGQgY29sc3Bhbj0iMiI+PFRN UExfVkFSIE5BTUU9ImZpbGVfdXJpIiBFU0NBUEU9IkhUTUwiPjwvdGQ+CisgICAgICA8dGg+RGly ZWN0IElucHV0OjwvdGg+PHRkIGNvbHNwYW49IjIiPjx0ZXh0YXJlYSBpZD0iZnJhZ21lbnQiIG5h bWU9ImZyYWdtZW50IiByb3dzPSIxMiIgY29scz0iODAiPjxUTVBMX0xPT1AgTkFNRT0iZmlsZV9z b3VyY2UiPjxUTVBMX1ZBUiBOQU1FPSJmaWxlX3NvdXJjZV9saW5lIiBFU0NBUEU9IkhUTUwiPgor PC9UTVBMX0xPT1A+PC90ZXh0YXJlYT48L3RkPgogPFRNUExfRUxTRT4KICAgICAgIDx0aD48bGFi ZWwgdGl0bGU9IkFkZHJlc3Mgb2YgUGFnZSB0byBWYWxpZGF0ZSIgZm9yPSJ1cmkiPkFkZHJlc3M8 L2xhYmVsPjo8L3RoPgogICAgICAgPHRkIGNvbHNwYW49IjIiPjxpbnB1dCB0eXBlPSJ0ZXh0IiBp ZD0idXJpIiBuYW1lPSJ1cmkiIHZhbHVlPSI8VE1QTF9WQVIgTkFNRT0iZmlsZV91cmkiIEVTQ0FQ RT0iSFRNTCI+IiBzaXplPSI1MCIgLz48L3RkPgpAQCAtNTMsMjYgKzU0LDIxIEBACiAgICAgPHRy Pjx0aD48VE1QTF9WQVIgTkFNRT0ibmFtZSIgRVNDQVBFPSJIVE1MIj46PC90aD48dGQgY29sc3Bh bj0iMiI+PFRNUExfVkFSIE5BTUU9InZhbHVlIiBFU0NBUEU9IkhUTUwiIERFRkFVTFQ9Iih1bmRl ZmluZWQpIj48L3RkPjwvdHI+CiAgIDwvVE1QTF9MT09QPgogPC9UTVBMX0lGPgotPFRNUExfSUYg TkFNRT0iaXNfdXBsb2FkIj4KLSAgICA8dHI+PHRoPkVuY29kaW5nOjwvdGg+PHRkIGNvbHNwYW49 IjIiPjxUTVBMX1ZBUiBOQU1FPSJmaWxlX2NoYXJzZXQiIEVTQ0FQRT0iSFRNTCI+PC90ZD48L3Ry PgotICAgIDx0cj48dGg+RG9jdHlwZTo8L3RoPjx0ZCBjb2xzcGFuPSIyIj48VE1QTF9WQVIgTkFN RT0iZmlsZV92ZXJzaW9uIiBFU0NBUEU9IkhUTUwiPjwvdGQ+PC90cj4KKzxUTVBMX0lGIE5BTUU9 ImZpbGVfY2hhcnNldCI+CisgIDx0cj4KKyAgICA8dGg+PGxhYmVsIHRpdGxlPSJDaGFyYWN0ZXIg RW5jb2RpbmciIGZvcj0iY2hhcnNldCI+RW5jb2Rpbmc8L2xhYmVsPjo8L3RoPgorICAgIDx0ZD48 VE1QTF9WQVIgTkFNRT0iZmlsZV9jaGFyc2V0IiBFU0NBUEU9IkhUTUwiPjwvdGQ+PHRkPjxUTVBM X0lOQ0xVREUgTkFNRT0icG9wdXBfY2hhcnNldC50bXBsIj48L3RkPgorICA8L3RyPgogPFRNUExf RUxTRT4KLSAgPFRNUExfSUYgTkFNRT0iZmlsZV9jaGFyc2V0Ij4KLSAgICA8dHI+Ci0gICAgICA8 dGg+PGxhYmVsIHRpdGxlPSJDaGFyYWN0ZXIgRW5jb2RpbmciIGZvcj0iY2hhcnNldCI+RW5jb2Rp bmc8L2xhYmVsPjo8L3RoPgotICAgICAgPHRkPjxUTVBMX1ZBUiBOQU1FPSJmaWxlX2NoYXJzZXQi IEVTQ0FQRT0iSFRNTCI+PC90ZD48dGQ+PFRNUExfSU5DTFVERSBOQU1FPSJwb3B1cF9jaGFyc2V0 LnRtcGwiPjwvdGQ+Ci0gICAgPC90cj4KLSAgPFRNUExfRUxTRT4KLSAgICA8dHI+PHRoPkVuY29k aW5nOjwvdGg+PHRkIGNvbHNwYW49IjIiPjxUTVBMX0lOQ0xVREUgTkFNRT0icG9wdXBfY2hhcnNl dC50bXBsIj48L3RkPjwvdHI+Ci0gIDwvVE1QTF9JRj4KLSAgPFRNUExfSUYgTkFNRT0iZmlsZV92 ZXJzaW9uIj4KLSAgICA8dHI+Ci0gICAgICA8dGg+PGxhYmVsIGZvcj0iZG9jdHlwZSIgdGl0bGU9 IkRvY3VtZW50IFR5cGUiPkRvY3R5cGU8L2xhYmVsPjo8L3RoPgotICAgICAgPHRkPjxUTVBMX1ZB UiBOQU1FPSJmaWxlX3ZlcnNpb24iIEVTQ0FQRT0iSFRNTCI+PC90ZD48dGQ+PFRNUExfSU5DTFVE RSBOQU1FPSJwb3B1cF9kb2N0eXBlLnRtcGwiPjwvdGQ+Ci0gICAgPC90cj4KLSAgPFRNUExfRUxT RT4KLSAgICA8dHI+PHRoPkRvY3R5cGU6PC90aD48dGQgY29sc3Bhbj0iMiI+PFRNUExfSU5DTFVE RSBOQU1FPSJwb3B1cF9kb2N0eXBlLnRtcGwiPjwvdGQ+PC90cj4KLSAgPC9UTVBMX0lGPgorICA8 dHI+PHRoPkVuY29kaW5nOjwvdGg+PHRkIGNvbHNwYW49IjIiPjxUTVBMX0lOQ0xVREUgTkFNRT0i cG9wdXBfY2hhcnNldC50bXBsIj48L3RkPjwvdHI+Cis8L1RNUExfSUY+Cis8VE1QTF9JRiBOQU1F PSJmaWxlX3ZlcnNpb24iPgorICA8dHI+CisgICAgPHRoPjxsYWJlbCBmb3I9ImRvY3R5cGUiIHRp dGxlPSJEb2N1bWVudCBUeXBlIj5Eb2N0eXBlPC9sYWJlbD46PC90aD4KKyAgICA8dGQ+PFRNUExf VkFSIE5BTUU9ImZpbGVfdmVyc2lvbiIgRVNDQVBFPSJIVE1MIj48L3RkPjx0ZD48VE1QTF9JTkNM VURFIE5BTUU9InBvcHVwX2RvY3R5cGUudG1wbCI+PC90ZD4KKyAgPC90cj4KKzxUTVBMX0VMU0U+ CisgIDx0cj48dGg+RG9jdHlwZTo8L3RoPjx0ZCBjb2xzcGFuPSIyIj48VE1QTF9JTkNMVURFIE5B TUU9InBvcHVwX2RvY3R5cGUudG1wbCI+PC90ZD48L3RyPgogPC9UTVBMX0lGPgogPFRNUExfSUYg TkFNRT0icm9vdF9lbGVtZW50Ij4KICAgPHRyPgpAQCAtOTgsNyArOTQsNiBAQAogPC9UTVBMX0lG PgogICA8L3RhYmxlPgogCi08VE1QTF9VTkxFU1MgTkFNRT0iaXNfdXBsb2FkIj4KICAgICAgICAg PGZpZWxkc2V0IGlkPSJyZXZhbGlkYXRlX29wdHMiPgogICAgICAgICAgICAgICAgICA8bGVnZW5k Pk9wdGlvbnM8L2xlZ2VuZD4KIApAQCAtMTQ5LDggKzE0NCw1IEBACiAgICAgICAgIDwvcD4KICAg ICAgICAgPGRpdiBpZD0icmV2YWxpZGF0ZV9idXR0b24iIGNsYXNzPSJzdWJtaXRfYnV0dG9uIj48 aW5wdXQgdHlwZT0ic3VibWl0IiB2YWx1ZT0iUmV2YWxpZGF0ZSIgdGl0bGU9IlZhbGlkYXRlIHRo aXMgZG9jdW1lbnQgYWdhaW4iIC8+PC9kaXY+CiAgIDwvZmllbGRzZXQ+Ci0gIAotICAKLTwvVE1Q TF9VTkxFU1M+CiA8L2Zvcm0+CiA8L1RNUExfSUY+CkluZGV4OiBodHRwZC9jZ2ktYmluL2NoZWNr Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3B1YmxpYy92YWxpZGF0b3IvaHR0cGQvY2dp LWJpbi9jaGVjayx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41NTkKZGlmZiAtdSAtcjEuNTU5IGNo ZWNrCi0tLSBodHRwZC9jZ2ktYmluL2NoZWNrCTMgU2VwIDIwMDcgMDY6NTc6NDEgLTAwMDAJMS41 NTkKKysrIGh0dHBkL2NnaS1iaW4vY2hlY2sJNSBTZXAgMjAwNyAwMjowODo0NSAtMDAwMApAQCAt OTYxLDggKzk2MSw3IEBACiAKICR0ZW1wbGF0ZS0+cGFyYW0oZmlsZV93YXJuaW5ncyA9PiAkRmls ZS0+e1dhcm5pbmdzfSk7CiAkdGVtcGxhdGUtPnBhcmFtKHRpZHlfb3V0cHV0ID0+ICRGaWxlLT57 J1RpZHknfSk7Ci0kdGVtcGxhdGUtPnBhcmFtKGZpbGVfc291cmNlID0+ICZzb3VyY2UoJEZpbGUp KQotICBpZiAkdGVtcGxhdGUtPnBhcmFtKCdvcHRfc2hvd19zb3VyY2UnKTsKKyR0ZW1wbGF0ZS0+ cGFyYW0oZmlsZV9zb3VyY2UgPT4gJnNvdXJjZSgkRmlsZSkpOwogIyR0ZW1wbGF0ZS0+cGFyYW0o J29wdF9zaG93X2VzaXMnID0+IFRSVUUpCiAjICBpZiAkRmlsZS0+e09wdH0tPnsnU2hvdyBFU0lT J307CiAjJHRlbXBsYXRlLT5wYXJhbSgnb3B0X3Nob3dfcmF3X2Vycm9ycycgPT4gVFJVRSkK