3974 2006-11-16 22:16:15 +0000 typos in input-file for trivial-{1,2,3,4} tests 2007-01-11 19:30:24 +0000 1 1 1 Unclassified XML Query Test Suite XML Query Test Suite unspecified PC Linux CLOSED FIXED P2 normal --- 1 per andrew.eisenberg public-qt-comments oldest_to_newest 12934 0 per 2006-11-16 22:16:15 +0000 The tests trivial-1 and trivial-2 both use the same query trivial-1.xq, and both declare an input-file binding to the variable "input-context". But trivial-1.xq needs an external variable $input-context1. Likewise, the tests trivial-3 and trivial-4 both declare the variable "input-context", and both use trivial-3.xq, which needs $input-context1. None of the queries actually *uses* $input-context1, so I'd just remove the variable declarations. 13188 1 carmelo 2006-12-14 20:34:54 +0000 Per: Thanks for the comment. I think you meant "trvial-1" and "trivial-3". I corrected the typo on the tests. Rather than removing the declaration alltogether I made it consistent with the catalog file as per out history. Marking this item as "FIXED". Please close the bug if in agreement. Thanks, Carmelo 13191 2 mike 2006-12-14 22:02:14 +0000 Since the "trivial embedding" has been dropped from the spec, these four tests ought to be removed. 13231 3 per 2006-12-18 06:18:59 +0000 (In reply to comment #1) > Thanks for the comment. I think you meant "trvial-1" and "trivial-3". I > corrected the typo on the tests. Rather than removing the declaration > alltogether I made it consistent with the catalog file as per out history. > Marking this item as "FIXED". Please close the bug if in agreement. I did a 'cvs update' and I don't see the fix. 13232 4 per 2006-12-18 06:29:58 +0000 (In reply to comment #2) > Since the "trivial embedding" has been dropped from the spec, these four tests > ought to be removed. Perhaps. The "trivial embedding" might be a reasonable thing to standardize, but the test-cases are somewhat beside the point. The trivial embeddeding is not a specification for XQuery per se, but rather a specification for how one might encapsulate XQuery inside an XML file. As such I don't see that the tests test for anything real - except that there is a way to evaluate a query passed in as a string. 13268 5 carmelo 2006-12-21 16:28:20 +0000 I double check them again and they look fine. Perhaps Michael is correct, we should remove these tests. Carmelo 13269 6 per 2006-12-21 18:16:25 +0000 (In reply to comment #5) > I double check them again and they look fine. The trivial-{1,3}.xq files are fixed, but the PublicPagesStagingArea/XQTS_current.zip file isn't updated. So I manually copied over trivial-{1,3}.xq and now tests trivial-1 and trivial-3 pass. > Perhaps Michael is correct, we should remove these tests. If you decide to keep the tests, I'll make a point of getting them working. As I said, it doesn't make sense to talk about XQuery implementing trivial embedding; just a matter of the *testsuite* implementing the trivial embedding. 13452 7 andrew.eisenberg 2007-01-11 19:29:45 +0000 I have removed the test cases for the Trivial XML Embedding Feature.