3787 2006-10-02 21:13:24 +0000 [XQuery] Code example I.4 with flaws 2006-10-11 22:38:09 +0000 1 1 1 Unclassified XPath / XQuery / XSLT XQuery 1.0 Candidate Recommendation PC Windows XP CLOSED FIXED P2 normal --- 1 hrennau chamberl public-qt-comments oldest_to_newest 12245 0 hrennau 2006-10-02 21:13:24 +0000 [XQuery] The function local:swizzle as described by the appendix has two flaws: a) text nodes are ignored, thus producing an output document without any text contents b) no care is taken to ensure that within an element constructor all attribute nodes are written before any element nodes, thus inviting runtime errors (a) could be solved by replacing the line { for $c in $e/(* | @*) return local:swizzle($c) } by the line { for $c in $e/(node() | @*) return local:swizzle($c) } (b) could be taken care of by adding a textual remark, e.g. something of this sort: "For the sake of simplicity, the sample code neglects to ensure that within an element constructor all attribute nodes are written before any element nodes. For example, it relies on <size> elements to have no preceding sibling elements." However, maybe it would be better to present safe code by just replacing the line { for $c in $e/(* | @*) return local:swizzle($c) } by { for $c in ( $e/@* except $e/@color, (: attribute -> attribute :) $e/size, (: elem -> attribute :) $e/@color, (: attribute -> elem :) $e/node() except $e/size ) (: elem -> elem :) return local:swizzle($c) } 12399 1 chamberl 2006-10-11 22:37:54 +0000 Hans-Juergen, Good catch! Thanks for notifying the working group of these errors. The next version of the XQuery specification will include the "safe code" corrections that you have proposed. Since the working group has accepted your suggestion in its entirety, I have changed the status of this bug to "Fixed and Closed." Regards, Don Chamberlin (for the Query Working Group)