3727 2006-09-14 17:59:26 +0000 insufficient testing of deep-equal 2006-09-26 06:22:36 +0000 1 1 1 Unclassified XML Query Test Suite XML Query Test Suite 1.0 PC Linux CLOSED FIXED P2 enhancement --- 1 per andrew.eisenberg public-qt-comments oldest_to_newest 11728 0 per 2006-09-14 17:59:26 +0000 The deep-equal function is fairly complex, but there is pretty minimal test coverave. Most of the tests compare atomic items, and those are useful. There are a few tests for non-singleton atomic sequences, but not many. Worst, the few tests for comparing nodes and nodes sequences are pretty useless. They seesm to fit this pattern: deep-equal($input-context1/PATH, $input-context1/PATH) I.e. the same expression yielding the same *identical* nodes for both arguments. An implementation that just tests node identity would pass. 12015 1 andrew.eisenberg 2006-09-25 21:13:44 +0000 Thanks for bringing this to our attention. I've added test cases fn-deep-equal-node-args-1 to fn-deep-equal-node-args-5 to the test suite. These test cases pass sequences of nodes that do not have the same identity to fn:deep-equal. Please close this bug report if you agree with this resolution. 12024 2 per 2006-09-26 06:22:36 +0000 Yes, this does provide some more meaningful testing. (It caught one silly bug in the Qexo implementation!) Thanks.