3627 2006-08-26 00:18:58 +0000 Validator incorrectly reports failure when using CSS2 grammar - parses full-length numeric escapes incorrectly 2007-07-17 07:24:10 +0000 1 1 1 Unclassified CSSValidator CSS 2.0 CSS Validator PC Windows XP RESOLVED FIXED P2 normal --- 1 cecil ot ylafon www-validator-cvs oldest_to_newest 11284 0 cecil 2006-08-26 00:18:58 +0000 I believe that the following CSS2 fragment is legal CSS, if my reading of CSS 2 is correct, yet the validator incorrectly reports an error with grammar=CSS2 selected. Test case: selector { color: gr\000065en; } Reasoning: in CSS2 no terminating space is required after a full-length numeric escape sequence, filled out to the maximum of six characters. So in CSS2 the property value is "red". See the productions for "escape" in the CSS2 grammar. [FYI, compare selector { color: gre\000065n; } selector { color: r\000065 d; } both of which is correctly reported as valid. It seems to be that the parser is reading characters after the sixth hex digit and parsing them as part of the number.] Regards, Cecil Ward. 14689 1 462 peter.zhelezniakov 2007-04-10 14:12:29 +0000 Created attachment 462 A patch The idea of the patch is to terminate parsing of an escape sequence when either a non-digit is encountered, or six chars has been processed. In both cases whitespace following the escape sequence, if any, is skipped. 14690 2 462 peter.zhelezniakov 2007-04-10 14:14:00 +0000 Comment on attachment 462 A patch The code in CssParser.convertStringIndex() fails to enforce the "no more than 6 chars" rule for escape sequences. In fact, it has a (count < 6) check, but fails to increment the counter. 14700 3 463 peter.zhelezniakov 2007-04-12 13:35:52 +0000 Created attachment 463 CSS1 allows escape sequences 4 chars long maximum CSS1 allows escape sequences to be 4 chars long maximum, while CSS2+ allows 6 chars. We need to conditionalize on CSS version. 14867 4 ot 2007-04-24 10:27:59 +0000 Peter, Your patch looks good to me. I commited it to CVS, so now we can test and move to prod if all looks good. Yves, will you have a chance to double-check the patch? 15822 5 ot 2007-07-17 07:24:10 +0000 CVS version now in production. Closing. 462 2007-04-10 14:12:29 +0000 2007-04-10 14:12:29 +0000 A patch 3627.patch text/plain 1403 peter.zhelezniakov SW5kZXg6IENzc1BhcnNlci5qYXZhCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3B1Ymxp Yy8yMDAyL2Nzcy12YWxpZGF0b3Ivb3JnL3czYy9jc3MvcGFyc2VyL2FuYWx5emVyL0Nzc1BhcnNl ci5qYXZhLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIxCmRpZmYgLXUgLXIxLjIxIENzc1BhcnNl ci5qYXZhCi0tLSBDc3NQYXJzZXIuamF2YQkyNiBBcHIgMjAwNiAxMjo0NDoxNSAtMDAwMAkxLjIx CisrKyBDc3NQYXJzZXIuamF2YQkxMCBBcHIgMjAwNyAxNDowOTo0MyAtMDAwMApAQCAtMzI3Nywx OCArMzI3NywxOCBAQAogICAgICAgICAgICAgICAgIGNhc2UgJ2EnOiBjYXNlICdiJzogY2FzZSAn Yyc6IGNhc2UgJ2QnOiBjYXNlICdlJzogY2FzZSAnZic6CiAgICAgICAgICAgICAgICAgY2FzZSAn QSc6IGNhc2UgJ0InOiBjYXNlICdDJzogY2FzZSAnRCc6IGNhc2UgJ0UnOiBjYXNlICdGJzoKICAg ICAgICAgICAgICAgICAgICAgaW50IG51bVZhbHVlID0gQ2hhcmFjdGVyLmRpZ2l0KGMsIDE2KTsK LSAgICAgICAgICAgICAgICAgICAgaW50IGNvdW50ID0gMDsKKyAgICAgICAgICAgICAgICAgICAg aW50IGNvdW50ID0gMTsKICAgICAgICAgICAgICAgICAgICAgaW50IHAgPSAxNjsKIAotICAgICAg ICAgICAgICAgICAgICB3aGlsZSAoaW5kZXggKyAxIDwgbGVuICYmIGNvdW50IDwgNikgeworICAg ICAgICAgICAgICAgICAgICB3aGlsZSAoaW5kZXggKyAxIDwgbGVuKSB7CiAgICAgICAgICAgICAg ICAgICAgICAgICBjID0gcy5jaGFyQXQoaW5kZXgrMSk7CiAKLSAgICAgICAgICAgICAgICAgICAg ICAgIGlmIChDaGFyYWN0ZXIuZGlnaXQoYywgMTYpICE9IC0xKSB7CisgICAgICAgICAgICAgICAg ICAgICAgICBpZiAoQ2hhcmFjdGVyLmRpZ2l0KGMsIDE2KSAhPSAtMSAmJiBjb3VudCsrIDwgNikg ewogICAgICAgICAgICAgICAgICAgICAgICAgICAgIG51bVZhbHVlID0gKG51bVZhbHVlICogMTYp ICsgQ2hhcmFjdGVyLmRpZ2l0KGMsIDE2KTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw ICo9IDE2OwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZGV4Kys7CiAgICAgICAgICAg ICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChj ID09ICcgJykgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChjID09ICcgJyB8fCBj ID09ICdcdCcpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gc2tpcCB0aGUg bGF0ZXN0IHdoaXRlIHNwYWNlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZGV4 Kys7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfQo= 463 2007-04-12 13:35:52 +0000 2007-04-12 13:35:52 +0000 CSS1 allows escape sequences 4 chars long maximum 3627.patch text/plain 1517 peter.zhelezniakov SW5kZXg6IENzc1BhcnNlci5qYXZhCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9zb3VyY2VzL3B1Ymxp Yy8yMDAyL2Nzcy12YWxpZGF0b3Ivb3JnL3czYy9jc3MvcGFyc2VyL2FuYWx5emVyL0Nzc1BhcnNl ci5qYXZhLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIxCmRpZmYgLXUgLXIxLjIxIENzc1BhcnNl ci5qYXZhCi0tLSBDc3NQYXJzZXIuamF2YQkyNiBBcHIgMjAwNiAxMjo0NDoxNSAtMDAwMAkxLjIx CisrKyBDc3NQYXJzZXIuamF2YQkxMiBBcHIgMjAwNyAxMzoyODowMiAtMDAwMApAQCAtMzI3Nywx OCArMzI3NywxOSBAQAogICAgICAgICAgICAgICAgIGNhc2UgJ2EnOiBjYXNlICdiJzogY2FzZSAn Yyc6IGNhc2UgJ2QnOiBjYXNlICdlJzogY2FzZSAnZic6CiAgICAgICAgICAgICAgICAgY2FzZSAn QSc6IGNhc2UgJ0InOiBjYXNlICdDJzogY2FzZSAnRCc6IGNhc2UgJ0UnOiBjYXNlICdGJzoKICAg ICAgICAgICAgICAgICAgICAgaW50IG51bVZhbHVlID0gQ2hhcmFjdGVyLmRpZ2l0KGMsIDE2KTsK LSAgICAgICAgICAgICAgICAgICAgaW50IGNvdW50ID0gMDsKKyAgICAgICAgICAgICAgICAgICAg aW50IGNvdW50ID0gMTsKICAgICAgICAgICAgICAgICAgICAgaW50IHAgPSAxNjsKLQotICAgICAg ICAgICAgICAgICAgICB3aGlsZSAoaW5kZXggKyAxIDwgbGVuICYmIGNvdW50IDwgNikgeworICAg ICAgICAgICAgICAgICAgICBpbnQgbWF4Q291bnQgPSAoYWMuZ2V0Q3NzVmVyc2lvbigpLmVxdWFs cygiY3NzMSIpID8gNCA6IDYpOworICAgICAgICAgICAgICAgICAgICAgICAgCisgICAgICAgICAg ICAgICAgICAgIHdoaWxlIChpbmRleCArIDEgPCBsZW4pIHsKICAgICAgICAgICAgICAgICAgICAg ICAgIGMgPSBzLmNoYXJBdChpbmRleCsxKTsKIAotICAgICAgICAgICAgICAgICAgICAgICAgaWYg KENoYXJhY3Rlci5kaWdpdChjLCAxNikgIT0gLTEpIHsKKyAgICAgICAgICAgICAgICAgICAgICAg IGlmIChDaGFyYWN0ZXIuZGlnaXQoYywgMTYpICE9IC0xICYmIGNvdW50KysgPCBtYXhDb3VudCkg ewogICAgICAgICAgICAgICAgICAgICAgICAgICAgIG51bVZhbHVlID0gKG51bVZhbHVlICogMTYp ICsgQ2hhcmFjdGVyLmRpZ2l0KGMsIDE2KTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw ICo9IDE2OwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZGV4Kys7CiAgICAgICAgICAg ICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChj ID09ICcgJykgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChjID09ICcgJyB8fCBj ID09ICdcdCcpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gc2tpcCB0aGUg bGF0ZXN0IHdoaXRlIHNwYWNlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZGV4 Kys7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfQo=